Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 6495092: Record the initial matrix when we begin picture-playback, and concat with (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by reed1
Modified:
11 years, 10 months ago
Reviewers:
DerekS, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Record the initial matrix when we begin picture-playback, and concat with that if we see a setMatrix command. In this way we can respect the caller's overall playback matrix environment. Committed: https://code.google.com/p/skia/source/detail?r=5409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/core/SkPicturePlayback.cpp View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2
reed1
I think we can also do something about drawSprite in the picture case, but that ...
11 years, 10 months ago (2012-09-05 20:55:57 UTC) #1
bsalomon
11 years, 10 months ago (2012-09-05 21:03:22 UTC) #2
LGTM

On 2012/09/05 20:55:57, reed1 wrote:
> I think we can also do something about drawSprite in the picture case, but
that
> will probably be a different CL.
> 
> Also wondering if we can/should enforce any master-clip constraints from the
> caller, in the case where the picture contains clip-smashing ops like Replace
or
> Union...

I think it makes the API cleaner if we did. But it gets back to the clip parens
idea we discussed the other day. We'd want to take the resolved original
resolved clip and intersect with the picture's current resolved clip. 

In the current implementation every op except diff and intersect can open up
areas of the device that were clipped out before playback.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b