Issue 6495071: Future proof luminance caches.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6495071: Future proof luminance caches. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bungeman

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
thakis

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Free caches on Term. #

Total comments: 2

Patch Set 3 : Make reset in Term debug only. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
M	include/core/SkPaint.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/SkGraphics.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1 2	2 chunks	+33 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

Updates things so that in the present we can free the gamma caches and in ...

11 years, 10 months ago (2012-08-31 21:19:55 UTC) #1

bungeman

See also http://code.google.com/p/chromium/issues/detail?id=144930 http://code.google.com/p/skia/issues/detail?id=825

11 years, 10 months ago (2012-08-31 22:07:40 UTC) #2

reed1

looks good, but I'm not sure we need to set the globals to anything afterwards, ...

11 years, 10 months ago (2012-09-04 13:36:59 UTC) #3

bungeman

https://codereview.appspot.com/6495071/diff/2001/src/core/SkPaint.cpp File src/core/SkPaint.cpp (right): https://codereview.appspot.com/6495071/diff/2001/src/core/SkPaint.cpp#newcode1686 src/core/SkPaint.cpp:1686: SkSafeUnref(gMaskGamma); On 2012/09/04 13:36:59, reed1 wrote: > Do we ...

11 years, 10 months ago (2012-09-04 13:48:39 UTC) #4

Committed revision 5382.

Expand All Messages | Collapse All Messages