Basically, this finishes something which was forgotten about when I first wrote this. The idea ...
11 years, 11 months ago
(2012-09-11 20:37:16 UTC)
#1
Basically, this finishes something which was forgotten about when I first wrote
this. The idea was to have selection lists for each bench setting (things on the
first line of bench output, like antialias=0) which has different values across
lines. This change simply gives them their own column and column header, as
opposed to squeezing them and being anonymous.
On 2012/09/11 20:37:16, bungeman wrote: > Basically, this finishes something which was forgotten about when ...
11 years, 11 months ago
(2012-09-12 19:32:35 UTC)
#2
On 2012/09/11 20:37:16, bungeman wrote:
> Basically, this finishes something which was forgotten about when I first
wrote
> this. The idea was to have selection lists for each bench setting (things on
the
> first line of bench output, like antialias=0) which has different values
across
> lines. This change simply gives them their own column and column header, as
> opposed to squeezing them and being anonymous.
LGTM
On 2012/09/12 19:32:35, EricB wrote: > On 2012/09/11 20:37:16, bungeman wrote: > > Basically, this ...
11 years, 11 months ago
(2012-09-12 19:33:33 UTC)
#3
On 2012/09/12 19:32:35, EricB wrote:
> On 2012/09/11 20:37:16, bungeman wrote:
> > Basically, this finishes something which was forgotten about when I first
> wrote
> > this. The idea was to have selection lists for each bench setting (things on
> the
> > first line of bench output, like antialias=0) which has different values
> across
> > lines. This change simply gives them their own column and column header, as
> > opposed to squeezing them and being anonymous.
>
> LGTM
FWIW, Elliot and Ravi have much more Python experience than I and would be good
to have on a review.
Issue 6494118: Provide labels for variant settings in bench graph.
(Closed)
Created 11 years, 11 months ago by bungeman
Modified 11 years, 11 months ago
Reviewers: EricB
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0