Wrap all GrCustomStage textures in GrTextureAccess, remove StageDesc::fInConfigFlags

[bsalomon, 2012-09-11 14:30:14]

Tom, I've been CCing you on these types of changes (rather than Reviewersing
you) because of clock-skew and I'm not sure how much time you want to devote to
this stuff. But your comments/reviews are more than welcome.

[robertphillips, 2012-09-11 15:05:18]

LGTM + odd & ends

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess.h
File include/gpu/GrTextureAccess.h (right):

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess....
include/gpu/GrTextureAccess.h:30: /**
Comment a bit garbled

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess....
include/gpu/GrTextureAccess.h:65: char                    fSwizzle[5];
uint32_t seems bit of an overkill here

https://codereview.appspot.com/6494114/diff/1019/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.appspot.com/6494114/diff/1019/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShaderPriv.h:233: 
add virtual keywords?

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp
File src/gpu/GrTextureAccess.cpp (right):

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp#...
src/gpu/GrTextureAccess.cpp:30: 
Doesn't fTexture take its own ref?

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp#...
src/gpu/GrTextureAccess.cpp:35: fSwizzle[4] = '\0';
Why not just use: for (int i = 0; i < 4; ++i) and leave the manual break after
the switch?

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
src/gpu/gl/GrGLShaderBuilder.cpp:57: 
garbled comment?

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
src/gpu/gl/GrGLShaderBuilder.cpp:60: char alphaChar = caps.textureRedSupport() ?
'r' : 'a';
for loop?

[TomH, 2012-09-11 15:27:36]

I appreciated the ccs. I didn't really touch them while I was not-in-the-office,
then spent time last week catching up. Happy at what I see being wrought out of
my muddle.

[bsalomon, 2012-09-11 17:55:32]

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess.h
File include/gpu/GrTextureAccess.h (right):

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess....
include/gpu/GrTextureAccess.h:30: /**
On 2012/09/11 15:05:19, robertphillips wrote:
> Comment a bit garbled

Done.

https://codereview.appspot.com/6494114/diff/1019/include/gpu/GrTextureAccess....
include/gpu/GrTextureAccess.h:65: char                    fSwizzle[5];
On 2012/09/11 15:05:19, robertphillips wrote:
> uint32_t seems bit of an overkill here

the extra few bytes seemed trivial compared to reading/writing less than a word.

https://codereview.appspot.com/6494114/diff/1019/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.appspot.com/6494114/diff/1019/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShaderPriv.h:233: 
On 2012/09/11 15:05:19, robertphillips wrote:
> add virtual keywords?

Done.

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp
File src/gpu/GrTextureAccess.cpp (right):

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp#...
src/gpu/GrTextureAccess.cpp:30: 
On 2012/09/11 15:05:19, robertphillips wrote:
> Doesn't fTexture take its own ref?

SkAutoTUnref unrefs, doesn't ref.

https://codereview.appspot.com/6494114/diff/1019/src/gpu/GrTextureAccess.cpp#...
src/gpu/GrTextureAccess.cpp:35: fSwizzle[4] = '\0';
On 2012/09/11 15:05:19, robertphillips wrote:
> Why not just use: for (int i = 0; i < 4; ++i) and leave the manual break after
> the switch?

Changed to do/while ('\0' != swizzle[i] && ++i < 4).

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
src/gpu/gl/GrGLShaderBuilder.cpp:57: 
On 2012/09/11 15:05:19, robertphillips wrote:
> garbled comment?

Done.

https://codereview.appspot.com/6494114/diff/1019/src/gpu/gl/GrGLShaderBuilder...
src/gpu/gl/GrGLShaderBuilder.cpp:60: char alphaChar = caps.textureRedSupport() ?
'r' : 'a';
On 2012/09/11 15:05:19, robertphillips wrote:
> for loop?

Changed to:
        int i;
        for (i = 0; '\0' != swizzle[i]; ++i) {
            mangledSwizzle[i] = alphaChar;
        }
(need i after the loop).

[bsalomon, 2012-09-11 17:56:17]

Closed with r5485.