Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2007)

Issue 6494105: code review 6494105: go.crypto/poly1305: add package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by agl1
Modified:
7 years, 3 months ago
Reviewers:
CC:
golang-dev, dchest
Visibility:
Public.

Description

go.crypto/poly1305: add package. (Reference implementation by dchest. amd64 disabled pending 6l fix.)

Patch Set 1 #

Patch Set 2 : diff -r 05426f7f4922 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 05426f7f4922 https://code.google.com/p/go.crypto #

Total comments: 5

Patch Set 4 : diff -r 05426f7f4922 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2192 lines, -0 lines) Patch
A poly1305/const_amd64.s View 1 1 chunk +43 lines, -0 lines 0 comments Download
A poly1305/poly1305.go View 1 1 chunk +32 lines, -0 lines 0 comments Download
A poly1305/poly1305_amd64.s.needs103 View 1 1 chunk +495 lines, -0 lines 0 comments Download
A poly1305/poly1305_test.go View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A poly1305/sum_amd64.go.needs103 View 1 1 chunk +19 lines, -0 lines 0 comments Download
A poly1305/sum_ref.go View 1 2 3 1 chunk +1529 lines, -0 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: dchest@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
7 years, 3 months ago (2012-09-08 15:00:56 UTC) #1
dchest
LGTM https://codereview.appspot.com/6494105/diff/3007/poly1305/poly1305_test.go File poly1305/poly1305_test.go (right): https://codereview.appspot.com/6494105/diff/3007/poly1305/poly1305_test.go#newcode15 poly1305/poly1305_test.go:15: /*{ Uncomment this? https://codereview.appspot.com/6494105/diff/3007/poly1305/poly1305_test.go#newcode37 poly1305/poly1305_test.go:37: func foo() ? ...
7 years, 3 months ago (2012-09-08 16:04:19 UTC) #2
agl1
7 years, 3 months ago (2012-09-08 18:25:08 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=687cc4af753a&repo=crypto ***

go.crypto/poly1305: add package.

(Reference implementation by dchest. amd64 disabled pending 6l fix.)

R=golang-dev, dchest
CC=golang-dev
http://codereview.appspot.com/6494105

http://codereview.appspot.com/6494105/diff/3007/poly1305/poly1305_test.go
File poly1305/poly1305_test.go (right):

http://codereview.appspot.com/6494105/diff/3007/poly1305/poly1305_test.go#new...
poly1305/poly1305_test.go:15: /*{
On 2012/09/08 16:04:19, dchest wrote:
> Uncomment this?

Ah, thank you! I had this left over here from debugging a linker problem.

http://codereview.appspot.com/6494105/diff/3007/poly1305/sum_ref.go
File poly1305/sum_ref.go (right):

http://codereview.appspot.com/6494105/diff/3007/poly1305/sum_ref.go#newcode14
poly1305/sum_ref.go:14: OutputSize = 16
On 2012/09/08 16:04:19, dchest wrote:
> I think both KeySize and OutputSize can be removed.

Yep, didn't notice these as godoc was skipping _ref.go. Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b