Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 6494084: code review 6494084: oauth: Add a bit of context to the error message for up...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by manugarg1
Modified:
8 years, 11 months ago
Reviewers:
adg
CC:
adg, golang-dev
Visibility:
Public.

Description

oauth: Add a bit of context to the error message for update token errors. It's particulary important when update token is called implicitly during HTTP roundtrip. Without context, it gives an impression that the URL being fetched by HTTP client has a problem.

Patch Set 1 #

Patch Set 2 : code review 6494084: oauth: Add a bit of context to the error message for up... #

Patch Set 3 : code review 6494084: oauth: Add a bit of context to the error message for up... #

Patch Set 4 : code review 6494084: oauth: Add a bit of context to the error message for up... #

Patch Set 5 : diff -r 76d44ce1c666 https://code.google.com/p/goauth2/ #

Patch Set 6 : diff -r 76d44ce1c666 https://code.google.com/p/goauth2/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M oauth/oauth.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
manugarg1
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2/
9 years, 10 months ago (2012-09-05 12:37:23 UTC) #1
adg
LGTM
9 years, 10 months ago (2012-09-06 01:01:05 UTC) #2
adg
For me to accept this change you must sign the contributor license agreement http://golang.org/doc/contribute.html#Copyright On ...
9 years, 10 months ago (2012-09-06 01:03:58 UTC) #3
manugarg1
Done. On Thu, Sep 6, 2012 at 6:33 AM, Andrew Gerrand <adg@golang.org> wrote: > For ...
9 years, 10 months ago (2012-09-06 04:32:40 UTC) #4
adg
*** Submitted as http://code.google.com/p/goauth2/source/detail?r=ee227149d571 *** oauth: Add a bit of context to the error message ...
9 years, 10 months ago (2012-09-06 05:13:25 UTC) #5
remyoudompheng
8 years, 11 months ago (2013-07-21 19:58:48 UTC) #6
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b