Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 6494083: fix css regexp optimization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by felix8a
Modified:
13 years, 9 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

if you give "border: 1px solid rgb(0,0,0)" to the js css sanitizer, it stripes out the rgb value, because of a bug in our regexp optimizer. the optimizer turns /foo{0}/ into /foo/ rather than // so the pattern /(rgb...)(rgb...){0}/ becomes /(rgb...)(rgb...)/ which is the wrong thing to match. this fixes https://code.google.com/p/google-caja/issues/detail?id=1517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/com/google/caja/lang/css/JSRE.java View 1 chunk +2 lines, -1 line 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 2 chunks +10 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/sanitizecss_test.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
13 years, 9 months ago (2012-09-05 00:18:50 UTC) #1
metaweta
lgtm
13 years, 9 months ago (2012-09-05 00:21:17 UTC) #2
felix8a
13 years, 9 months ago (2012-09-05 00:31:14 UTC) #3
@r5036
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b