Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 6494082: Emit "#version 120" if the shader has array as out parameter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Alok Priyadarshi
Modified:
12 years, 11 months ago
CC:
angleproject-review_googlegroups.com, VangelisK
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Emit "#version 120" if the shader has array as out parameter. Committed: https://code.google.com/p/angleproject/source/detail?r=1273

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M src/compiler/VersionGLSL.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/compiler/VersionGLSL.cpp View 1 3 chunks +31 lines, -6 lines 0 comments Download

Messages

Total messages: 7
Alok Priyadarshi
12 years, 11 months ago (2012-09-04 22:26:09 UTC) #1
gmanchromium
On 2012/09/04 22:26:09, Alok Priyadarshi wrote: Is there a test for the WebGL Conformance Tests ...
12 years, 11 months ago (2012-09-04 22:44:53 UTC) #2
sabercrombie
This works for me. The game runs without corruption and I confirmed in the debugger ...
12 years, 11 months ago (2012-09-04 23:13:03 UTC) #3
dgkoch
LGTM https://codereview.appspot.com/6494082/diff/1/src/compiler/VersionGLSL.cpp File src/compiler/VersionGLSL.cpp (right): https://codereview.appspot.com/6494082/diff/1/src/compiler/VersionGLSL.cpp#newcode2 src/compiler/VersionGLSL.cpp:2: // Copyright (c) 2002-2010 The ANGLE Project Authors. ...
12 years, 11 months ago (2012-09-05 02:29:30 UTC) #4
nicolas
Looks fine to me too.
12 years, 11 months ago (2012-09-05 15:50:03 UTC) #5
Alok Priyadarshi
On 2012/09/04 22:44:53, gmanchromium wrote: > On 2012/09/04 22:26:09, Alok Priyadarshi wrote: > > Is ...
12 years, 11 months ago (2012-09-06 16:00:35 UTC) #6
Alok Priyadarshi
12 years, 11 months ago (2012-09-06 16:02:40 UTC) #7
https://codereview.appspot.com/6494082/diff/1/src/compiler/VersionGLSL.cpp
File src/compiler/VersionGLSL.cpp (right):

https://codereview.appspot.com/6494082/diff/1/src/compiler/VersionGLSL.cpp#ne...
src/compiler/VersionGLSL.cpp:2: // Copyright (c) 2002-2010 The ANGLE Project
Authors. All rights reserved.
On 2012/09/05 02:29:30, dgkoch wrote:
> -2012

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b