Issue 6494057: state: write agent tools version into initial EnvironConfig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6494057: state: write agent tools version into initial EnvironConfig

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
niemeyer, mp+122019

Visibility:
Public.

Description

state: write agent tools version into initial EnvironConfig We will use this mechanism to trigger upgrades. Note that because we use the EnvironConfig to hold the version, environment providers can no longer be strict about the fields they accept. https://code.launchpad.net/~rogpeppe/juju-core/039-init-agent-version/+merge/122019 Requires: https://code.launchpad.net/~rogpeppe/juju-core/041-config-agent-version/+merge/122016 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: write agent tools version into initial EnvironConfig #

Total comments: 1

Patch Set 3 : state: write agent tools version into initial EnvironConfig #

Patch Set 4 : state: write agent tools version into initial EnvironConfig #

Patch Set 5 : state: write agent tools version into initial EnvironConfig #

Patch Set 6 : state: write agent tools version into initial EnvironConfig #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View	1 2	3 chunks	+11 lines, -4 lines	0 comments	Download
M	cmd/jujud/provisioning_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/dummy/environs.go	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/6494057/diff/2001/state/open.go File state/open.go (right): https://codereview.appspot.com/6494057/diff/2001/state/open.go#newcode120 state/open.go:120: n.Set("agent-version", version.Current.Number.String()) It'd be nice to avoid yet another ...

11 years, 8 months ago (2012-08-30 10:17:53 UTC) #2

niemeyer

11 years, 8 months ago (2012-08-30 15:06:21 UTC) #4

We've discussed the use of environs.BootstrapConfig on IRC.

Expand All Messages | Collapse All Messages