Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 6494052: Add ANGLE to DEPS, integrate build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by EricB
Modified:
12 years, 3 months ago
Reviewers:
epoger, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add ANGLE to DEPS, integrate build Committed: https://code.google.com/p/skia/source/detail?r=5387

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 9

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M DEPS View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M gyp/angle.gyp View 1 2 3 4 5 1 chunk +20 lines, -10 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
EricB
Not included in this CL: I had to copy the contents of third_party/externals/angle/src/build_angle.gyp into third_party/externals/angle/src/build_angle.gypi ...
12 years, 3 months ago (2012-08-29 17:23:59 UTC) #1
epoger
Looks fine at patchset 4, but I'll wait until the needed build_angle.gypi change goes into ...
12 years, 3 months ago (2012-08-29 17:31:40 UTC) #2
robertphillips
LGTM http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi File gyp/common_variables.gypi (right): http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode47 gyp/common_variables.gypi:47: 'skia_os%': '<(OS)', You can delete this comment - ...
12 years, 3 months ago (2012-08-29 17:32:55 UTC) #3
EricB
Uploaded Patch Set 5. We're depending on the ANGLE CL, which is uploaded for review ...
12 years, 3 months ago (2012-08-29 18:00:24 UTC) #4
epoger
LGTM at patchset 5!
12 years, 3 months ago (2012-08-29 19:00:22 UTC) #5
EricB
On 2012/08/29 19:00:22, epoger wrote: > LGTM at patchset 5! Uploaded patch set 6 after ...
12 years, 3 months ago (2012-08-30 21:45:50 UTC) #6
epoger
12 years, 3 months ago (2012-09-04 16:06:41 UTC) #7
LGTM at patchset 6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b