Add ANGLE to DEPS, integrate build

Add ANGLE to DEPS, integrate build
Committed: https://code.google.com/p/skia/source/detail?r=5387

[EricB, 2012-08-29 17:23:59]

Not included in this CL: I had to copy the contents of
third_party/externals/angle/src/build_angle.gyp into
third_party/externals/angle/src/build_angle.gypi and write a new build_angle.gyp
which just includes build_angle.gypi.  I'm going to upload a CL to ANGLE for
this.

[epoger, 2012-08-29 17:31:40]

Looks fine at patchset 4, but I'll wait until the needed build_angle.gypi change
goes into the angle repo before approving...

http://codereview.appspot.com/6494052/diff/8/DEPS
File DEPS (right):

http://codereview.appspot.com/6494052/diff/8/DEPS#newcode11
DEPS:11: "third_party/externals/angle" :
"http://angleproject.googlecode.com/svn/trunk@1267",
I can't tell if you already did this... but please update the "SVN externals"
dependency also, as noted above.

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode68
gyp/common_variables.gypi:68: 'skia_win_exceptions%': '1',
Why is skia_win_exceptions dependent on whether we're using ANGLE?

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode82
gyp/common_variables.gypi:82: 'component%': 'static_library', # Needed by
.../angle/src/build_angle.gyp
Yikes.  Setting such a generically named variable, in a place where it will be
included by so many gyp files, is a bit scary.  But I guess it's the least-bad
option...

[robertphillips, 2012-08-29 17:32:55]

LGTM

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode47
gyp/common_variables.gypi:47: 'skia_os%': '<(OS)',
You can delete this comment - I think you've made it real

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode65
gyp/common_variables.gypi:65: 'skia_arch_width%': 32,
Why do we have to fiddle with exceptions?

[EricB, 2012-08-29 18:00:24]

Uploaded Patch Set 5.  We're depending on the ANGLE CL, which is uploaded for
review here: http://codereview.appspot.com/6495055/

http://codereview.appspot.com/6494052/diff/8/DEPS
File DEPS (right):

http://codereview.appspot.com/6494052/diff/8/DEPS#newcode11
DEPS:11: "third_party/externals/angle" :
"http://angleproject.googlecode.com/svn/trunk@1267",
On 2012/08/29 17:31:40, epoger wrote:
> I can't tell if you already did this... but please update the "SVN externals"
> dependency also, as noted above.

Whoops!  I hadn't, but just did.  I guess those properties aren't uploaded as a
diff here, huh?

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode47
gyp/common_variables.gypi:47: 'skia_os%': '<(OS)',
On 2012/08/29 17:32:55, robertphillips wrote:
> You can delete this comment - I think you've made it real

Done.

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode65
gyp/common_variables.gypi:65: 'skia_arch_width%': 32,
On 2012/08/29 17:32:55, robertphillips wrote:
> Why do we have to fiddle with exceptions?

Compiling with 'ExceptionHandling': '0' causes lots of warnings because ANGLE
uses STL and therefore has a number of try/catch blocks.  I mistakenly
attributed subsequent compile errors to these warnings.  I removed this and the
compile succeeds with said warnings.

http://codereview.appspot.com/6494052/diff/8/gyp/common_variables.gypi#newcode82
gyp/common_variables.gypi:82: 'component%': 'static_library', # Needed by
.../angle/src/build_angle.gyp
On 2012/08/29 17:31:40, epoger wrote:
> Yikes.  Setting such a generically named variable, in a place where it will be
> included by so many gyp files, is a bit scary.  But I guess it's the least-bad
> option...

Moved into angle.gyp.

[epoger, 2012-08-29 19:00:22]

LGTM at patchset 5!

[EricB, 2012-08-30 21:45:50]

On 2012/08/29 19:00:22, epoger wrote:
> LGTM at patchset 5!

Uploaded patch set 6 after http://codereview.appspot.com/6495055/ was committed
as ANGLE r1268.

Change ANGLE revision in DEPS to 1268.

In order to make the reviewer for that CL happy, I had to roll GYP forward to
r1488.  Our DEPS and svn properties were our of sync at 1320 and 1284,
respectively, so I'm rolling those to 1488 with this CL as well.

[epoger, 2012-09-04 16:06:41]

LGTM at patchset 6