Issue 6493086: ASan: Continue after error -- compiler-rt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6493086: ASan: Continue after error -- compiler-rt

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by reidw

Modified:
12 years, 2 months ago

Reviewers:
kcc1

Base URL:
http://llvm.org/svn/llvm-project/compiler-rt/trunk/

Visibility:
Public.

Description

Continue after an error in AddressSanitizer -- compiler-rt half.

Patch Set 1 : Keep going in compiler-rt #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+109 lines, -49 lines)			Patch
include/sanitizer/asan_interface.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
lib/asan/asan_report.cc	View	2 chunks	+54 lines, -49 lines	1 comment	Download
lib/asan/asan_rtl.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
lib/asan/lit_tests/interface_symbols.c	View	1 chunk	+10 lines, -0 lines	0 comments	Download
lib/asan/lit_tests/multiple-errors.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

kcc1

12 years, 2 months ago (2012-09-06 13:30:01 UTC) #1

https://codereview.appspot.com/6493086/diff/3006/lib/asan/asan_report.cc
File lib/asan/asan_report.cc (right):

https://codereview.appspot.com/6493086/diff/3006/lib/asan/asan_report.cc#newc...
lib/asan/asan_report.cc:426: Printf("========================== ERROR
==========================\n");
don't we need a lock here to avoid mixup of warnings from different threads?

Expand All Messages | Collapse All Messages