Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1017)

Issue 6493075: Add effects/core.gypi to 'sources' to make them appear in VS projects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bsalomon
Modified:
12 years, 2 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gyp/core.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gyp/effects.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gyp/gpu.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
bsalomon
This doesn't change anything about the build. It just makes it easier to get to ...
12 years, 2 months ago (2012-09-04 13:43:04 UTC) #1
reed1
Since these lines *appear* to be duplicates of the ones in 'includes' that reference these ...
12 years, 2 months ago (2012-09-04 14:29:59 UTC) #2
bsalomon
On 2012/09/04 14:29:59, reed1 wrote: > Since these lines *appear* to be duplicates of the ...
12 years, 2 months ago (2012-09-04 14:33:44 UTC) #3
reed1
lgtm
12 years, 2 months ago (2012-09-04 14:36:01 UTC) #4
bsalomon
12 years, 2 months ago (2012-09-04 14:37:27 UTC) #5
Closed with 5384.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b