Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(686)

Issue 6492129: Fixed valgrind complaint in MatrixBench (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by robertphillips
Modified:
12 years, 2 months ago
Reviewers:
EricB, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Without this fix, valgrind complains of a jmp based on uninitialized memory in the mapRect call

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed fRect member variable & added comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M bench/MatrixBench.cpp View 1 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 6
robertphillips
12 years, 2 months ago (2012-09-17 12:26:10 UTC) #1
reed1
https://codereview.appspot.com/6492129/diff/1/bench/MatrixBench.cpp File bench/MatrixBench.cpp (right): https://codereview.appspot.com/6492129/diff/1/bench/MatrixBench.cpp#newcode368 bench/MatrixBench.cpp:368: } // comment on why 0,0,10,10 ?
12 years, 2 months ago (2012-09-17 12:30:35 UTC) #2
robertphillips
https://codereview.appspot.com/6492129/diff/1/bench/MatrixBench.cpp File bench/MatrixBench.cpp (right): https://codereview.appspot.com/6492129/diff/1/bench/MatrixBench.cpp#newcode368 bench/MatrixBench.cpp:368: } Random, valid, small rect. I figured anything would ...
12 years, 2 months ago (2012-09-17 12:32:31 UTC) #3
robertphillips
PTAL
12 years, 2 months ago (2012-09-17 12:42:37 UTC) #4
reed1
lgtm w/ SkIntToScalar nit https://codereview.appspot.com/6492129/diff/3002/bench/MatrixBench.cpp File bench/MatrixBench.cpp (right): https://codereview.appspot.com/6492129/diff/3002/bench/MatrixBench.cpp#newcode388 bench/MatrixBench.cpp:388: // an arbitrary, small, non-zero ...
12 years, 2 months ago (2012-09-17 12:43:59 UTC) #5
robertphillips
12 years, 2 months ago (2012-09-17 13:37:20 UTC) #6
committed as r5566

https://codereview.appspot.com/6492129/diff/3002/bench/MatrixBench.cpp
File bench/MatrixBench.cpp (right):

https://codereview.appspot.com/6492129/diff/3002/bench/MatrixBench.cpp#newcod...
bench/MatrixBench.cpp:388: // an arbitrary, small, non-zero rect to transform
On 2012/09/17 12:43:59, reed1 wrote:
> SkIntToRect(10)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b