Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 6492120: Sample python client code for Enterprise License Manager API.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by smarquardt_google
Modified:
13 years, 3 months ago
Reviewers:
jcgregorio_google
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Enterprise License Manager API sample code, switched to gflags for consistency. #

Total comments: 2

Patch Set 3 : License Manager API samples, added iteration for long lists and optional maxResults param. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -0 lines) Patch
A samples/licensing/README View 1 chunk +4 lines, -0 lines 0 comments Download
A samples/licensing/client_secrets.json View 1 chunk +9 lines, -0 lines 0 comments Download
A samples/licensing/licensing.py View 1 2 1 chunk +418 lines, -0 lines 2 comments Download

Messages

Total messages: 5
jcgregorio_google
https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py File samples/licensing/licensing.py (right): https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#newcode30 samples/licensing/licensing.py:30: from optparse import OptionParser To be consistent with the ...
13 years, 3 months ago (2012-09-14 03:01:46 UTC) #1
smarquardt_google
Notes inline. On 2012/09/14 03:01:46, jcgregorio_google wrote: > https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py > File samples/licensing/licensing.py (right): > > ...
13 years, 3 months ago (2012-09-14 05:47:54 UTC) #2
jcgregorio_google
https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py File samples/licensing/licensing.py (right): https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py#newcode139 samples/licensing/licensing.py:139: customerId=customerId).execute() Should also use listForProduct_next to iterate through the ...
13 years, 3 months ago (2012-09-17 19:03:52 UTC) #3
smarquardt_google
On 2012/09/17 19:03:52, jcgregorio_google wrote: > https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py > File samples/licensing/licensing.py (right): > > https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py#newcode139 > ...
13 years, 3 months ago (2012-09-20 05:11:23 UTC) #4
jcgregorio_google
13 years, 3 months ago (2012-09-20 17:00:10 UTC) #5
https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing.py
File samples/licensing/licensing.py (right):

https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing....
samples/licensing/licensing.py:90: gflags.DEFINE_string('maxResults', None, 'The
maximum number of results to '
Shouldn't maxResults be an integer and not a string?

https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing....
samples/licensing/licensing.py:373: if FLAGS.maxResults:
Isn't the default for maxResults already set to None?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b