Sample python client code for Enterprise License Manager API.

[jcgregorio_google, 2012-09-14 03:01:46]

https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py
File samples/licensing/licensing.py (right):

https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
samples/licensing/licensing.py:30: from optparse import OptionParser
To be consistent with the rest of the samples please use gflags for all the
flags processing.

https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
samples/licensing/licensing.py:160: print '\nLicense assigned:\n User: %s\n
Product: %s\n SKU: %s\n' % (licenseList['userId'],
80 chars.

Also consider using string.Template.

https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
samples/licensing/licensing.py:267:
scope='https://www.googleapis.com/auth/apps.licensing',
80 chars

[smarquardt_google, 2012-09-14 05:47:54]

Notes inline.

On 2012/09/14 03:01:46, jcgregorio_google wrote:
> https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py
> File samples/licensing/licensing.py (right):
> 
>
https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
> samples/licensing/licensing.py:30: from optparse import OptionParser
> To be consistent with the rest of the samples please use gflags for all the
> flags processing.

Done.

 
>
https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
> samples/licensing/licensing.py:160: print '\nLicense assigned:\n User: %s\n
> Product: %s\n SKU: %s\n' % (licenseList['userId'],
> 80 chars.
> 
> Also consider using string.Template.

Fixed this and other instances of >80 chars.  Looked at using string.Template
but kept current syntax for consistency.

>
https://codereview.appspot.com/6492120/diff/1/samples/licensing/licensing.py#...
> samples/licensing/licensing.py:267:
> scope='https://www.googleapis.com/auth/apps.licensing',
> 80 chars

Done.

[jcgregorio_google, 2012-09-17 19:03:52]

https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py
File samples/licensing/licensing.py (right):

https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing....
samples/licensing/licensing.py:139: customerId=customerId).execute()
Should also use listForProduct_next to iterate through the extended list. Same
for lsitForProductAndSku.

See: https://developers.google.com/api-client-library/python/guide/pagination

https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing....
samples/licensing/licensing.py:299: storage = Storage('coordinate.dat')
maybe licensing.dat?

[smarquardt_google, 2012-09-20 05:11:23]

On 2012/09/17 19:03:52, jcgregorio_google wrote:
>
https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing.py
> File samples/licensing/licensing.py (right):
> 
>
https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing....
> samples/licensing/licensing.py:139: customerId=customerId).execute()
> Should also use listForProduct_next to iterate through the extended list. Same
> for lsitForProductAndSku.
> 
> See: https://developers.google.com/api-client-library/python/guide/pagination

I went ahead and added pagination and maxResults options to the listForProduct
and listForProductAndSku methods themselves, and now each will recurse (if
maxResults unspecified) until all results are returned (no pages left).  This
seemed truer to the actual API methods, which simply accept pageToken (page
identifier) and maxResults as optional params.
(https://developers.google.com/google-apps/licensing/v1/reference/licenseAssig...)


>
https://codereview.appspot.com/6492120/diff/3001/samples/licensing/licensing....
> samples/licensing/licensing.py:299: storage = Storage('coordinate.dat')
> maybe licensing.dat?

Good catch :)

[jcgregorio_google, 2012-09-20 17:00:10]

https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing.py
File samples/licensing/licensing.py (right):

https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing....
samples/licensing/licensing.py:90: gflags.DEFINE_string('maxResults', None, 'The
maximum number of results to '
Shouldn't maxResults be an integer and not a string?

https://codereview.appspot.com/6492120/diff/8001/samples/licensing/licensing....
samples/licensing/licensing.py:373: if FLAGS.maxResults:
Isn't the default for maxResults already set to None?