Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(622)

Issue 6492119: Add a header file for TransitionView.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by tfarina1
Modified:
12 years, 3 months ago
Reviewers:
yangsu, epoger
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add a header file for TransitionView.cpp This fixes the TODO in TransitionView.cpp. Signed-off-by: Thiago Farina <tfarina@chromium.org> Committed: https://code.google.com/p/skia/source/detail?r=5552 Committed: https://code.google.com/p/skia/source/detail?r=5554

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/iOSSampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +1 line, -1 line 0 comments Download
A samplecode/TransitionView.h View 1 chunk +15 lines, -0 lines 1 comment Download
M samplecode/TransitionView.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7
tfarina1
Please, take a look. https://codereview.appspot.com/6492119/diff/2001/samplecode/TransitionView.h File samplecode/TransitionView.h (right): https://codereview.appspot.com/6492119/diff/2001/samplecode/TransitionView.h#newcode2 samplecode/TransitionView.h:2: * Copyright 2012 Google Inc. ...
12 years, 3 months ago (2012-09-14 01:21:56 UTC) #1
epoger
LGTM I will commit this on your behalf later today, once http://skia.googlecode.com/svn/buildbot/buildbots.html is looking more ...
12 years, 3 months ago (2012-09-14 14:32:00 UTC) #2
tfarina1
On Fri, Sep 14, 2012 at 11:32 AM, <epoger@google.com> wrote: > LGTM > > I ...
12 years, 3 months ago (2012-09-14 14:45:15 UTC) #3
epoger
On Fri, Sep 14, 2012 at 10:45 AM, Thiago Farina <tfarina@chromium.org>wrote: > On Fri, Sep ...
12 years, 3 months ago (2012-09-14 15:14:57 UTC) #4
epoger
landed as https://code.google.com/p/skia/source/detail?r=5552
12 years, 3 months ago (2012-09-14 18:42:25 UTC) #5
epoger
On 2012/09/14 18:42:25, epoger wrote: > landed as https://code.google.com/p/skia/source/detail?r=5552 ... and https://code.google.com/p/skia/source/detail?r=5554 (whoops)
12 years, 3 months ago (2012-09-14 18:55:03 UTC) #6
tfarina1
12 years, 3 months ago (2012-09-15 00:54:21 UTC) #7
On Fri, Sep 14, 2012 at 12:14 PM, Elliot Poger <epoger@google.com> wrote:
>> > Thanks again for these contributions, Thiago.  Are you interested in
>> > becoming a Skia committer so that you can check out a writable copy and
>> > commit your own changes in the future?
>> >
>> Yup ;)
>
>
> OK, you are now a Skia committer.
Just saw the email now. Thank you for setting this up! :)

> In order to land your own changes, you'll need to check out a writable copy of
the repository; see
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> for instructions.
>
Right, I'll check out a writeable repository.

-- 
Thiago
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b