Issue 6492099: Exclude a use of ATSFont from the iOS build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492099: Exclude a use of ATSFont from the iOS build.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rohitrao

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://git.chromium.org/external/skia/src.git@master

Visibility:
Public.

More Reviews

Description

Exclude a use of ATSFont from the iOS build. BUG=None

Patch Set 2 : Add comment. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	ports/SkFontHost_mac_coretext.cpp	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rohitrao

Prereq for landing the skia.gyp changes. Please let me know what you think. I've never ...

11 years, 10 months ago (2012-09-10 19:25:51 UTC) #1

reed1

seems fine, though we should add a comment inline https://codereview.appspot.com/6492099/diff/1/ports/SkFontHost_mac_coretext.cpp File ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6492099/diff/1/ports/SkFontHost_mac_coretext.cpp#newcode366 ports/SkFontHost_mac_coretext.cpp:366: ...

11 years, 10 months ago (2012-09-10 19:39:03 UTC) #2

rohitrao

https://codereview.appspot.com/6492099/diff/1/ports/SkFontHost_mac_coretext.cpp File ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6492099/diff/1/ports/SkFontHost_mac_coretext.cpp#newcode366 ports/SkFontHost_mac_coretext.cpp:366: #if SK_BUILD_FOR_MAC On 2012/09/10 19:39:03, reed1 wrote: > Perhaps ...

11 years, 10 months ago (2012-09-10 19:44:29 UTC) #3

rohitrao

Thanks again for the review! What's the best way for me to get this landed ...

11 years, 10 months ago (2012-09-10 20:09:14 UTC) #5

Committed revision 5474.

Expand All Messages | Collapse All Messages