Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1468)

Issue 6492093: Remove extraneous const qualifier. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by tfarina1
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove extraneous const qualifier. Found by clang: [293/898] CXX obj/src/gpu/gl/gr.GrGpuGL.o ../../src/gpu/gl/GrGpuGL.cpp:2031:1: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] const GrGLenum tile_to_gl_wrap(SkShader::TileMode tm) { ^~~~~ Signed-off-by: Thiago Farina <tfarina@chromium.org>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
tfarina1
I don't have commit rights, as you might know. ;) So, when you approve, could ...
12 years, 2 months ago (2012-09-07 16:36:09 UTC) #1
bsalomon
12 years, 2 months ago (2012-09-07 16:54:43 UTC) #2
On 2012/09/07 16:36:09, tfarina1 wrote:
> I don't have commit rights, as you might know. ;)
> 
> So, when you approve, could you commit for me?
> 
> Thanks,

Thanks! LGTM. Committed as r5437.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b