Issue 6492091: download_baselines: allow user to select which builder's images to download

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492091: download_baselines: allow user to select which builder's images to download (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by epoger

Modified:
12 years, 2 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

download_baselines: allow user to select which builder's images to download BUG=806 Committed: https://code.google.com/p/skia/source/detail?r=5435

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -17 lines)			Patch
	M	tools/download_baselines.py	View	1 2	5 chunks	+56 lines, -17 lines	0 comments	Download
	M	tools/svn.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

I have tested this manually, and it works for both "old and new-style bots" (whether ...

12 years, 2 months ago (2012-09-07 15:53:59 UTC) #1

EricB

12 years, 2 months ago (2012-09-07 16:02:04 UTC) #2

On 2012/09/07 15:53:59, epoger wrote:
> I have tested this manually, and it works for both "old and new-style bots"
> (whether the builder_name was used when uploading or not)
> 
> Defaults to downloading 32-bit baselines.

Great!  LGTM

Expand All Messages | Collapse All Messages