Issue 6492084: Ensure texture level count accounts for lod offset.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492084: Ensure texture level count accounts for lod offset. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by John Bauman

Modified:
11 years, 8 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com, sminns

Base URL:
https://angleproject.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Ensure texture level count accounts for lod offset. The lower texture levels (below the lod offset) aren't used and can't be seen, so don't count them in levelCount. BUG= Committed: https://code.google.com/p/angleproject/source/detail?r=1275

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/libGLESv2/Texture.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/libGLESv2/Texture.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dgkoch

11 years, 8 months ago (2012-09-06 19:43:10 UTC) #3

On 2012/09/06 00:27:05, John Bauman wrote:
> This patch is originally from Steve Minns.

Can you add Steve to the CONTRIBUTORS file then?

Expand All Messages | Collapse All Messages