Issue 6492064: workaround for firefox defineProperty problem

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492064: workaround for firefox defineProperty problem (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by felix8a

Modified:
13 years, 7 months ago

Reviewers:
MarkM, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

current firefox complains if you defineProperty of a non-configurable property of window, and leave enumerable unspecified. that's supposed to succeed, leaving enumerability unchanged. this CL is a workaround, and with this change, firefox is now unsafe level 4 "Not isolated", rather than unsafe level 5 "New symptom". firefox bug is here https://bugzilla.mozilla.org/show_bug.cgi?id=787262

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/com/google/caja/ses/startSES.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

@r5032

Expand All Messages | Collapse All Messages