Issue 6492063: Move targets from src\build_angle.gyp to src\build_angle.gypi

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492063: Move targets from src\build_angle.gyp to src\build_angle.gypi (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by apatrick1

Modified:
11 years, 8 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move targets from src\build_angle.gyp to src\build_angle.gypi This enables Skia to compile ANGLE Committed: https://code.google.com/p/angleproject/source/detail?r=1268

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+345 lines, -326 lines)			Patch
M	CONTRIBUTORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/build_angle.gyp	View	1 chunk	+2 lines, -326 lines	0 comments	Download
A	src/build_angle.gypi	View	1 chunk	+342 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

11 years, 8 months ago (2012-08-30 22:23:32 UTC) #2

On 2012/08/30 22:05:18, Alok Priyadarshi wrote:
> What was the problem with .gyp file?

Oops, forgot to cross reference. I was landing this:
https://codereview.appspot.com/6495055/

Expand All Messages | Collapse All Messages