Issue 6491043: Take care of port 0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6491043: Take care of port 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Takashi Toyoshima

Modified:
13 years, 1 month ago

Reviewers:
tyoshino (chromium.org), bashi

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
https://pywebsocket.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Take care of port 0 If user specify port 0, the operating system assigned a free port. This port number should be shown as a log, and must be shared with other interfaces if user wants to listen at multiple ports. Also self.server_port should be updated to be refered by external code.

Patch Set 1 #

Total comments: 3

Patch Set 2 : interface -> socket #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/mod_pywebsocket/standalone.py	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Takashi Toyoshima

Hi bashi and tyoshino, Could you review this CL?

13 years, 1 month ago (2012-08-28 06:33:16 UTC) #1

bashi

On 2012/08/28 06:33:16, Takashi Toyoshima wrote: > Hi bashi and tyoshino, > Could you review ...

13 years, 1 month ago (2012-08-28 06:46:44 UTC) #2

tyoshino (chromium.org)

https://codereview.appspot.com/6491043/diff/1/src/mod_pywebsocket/standalone.py File src/mod_pywebsocket/standalone.py (right): https://codereview.appspot.com/6491043/diff/1/src/mod_pywebsocket/standalone.py#newcode423 src/mod_pywebsocket/standalone.py:423: if self.server_address[1] == 0: what happens if self._sockets contains ...

13 years, 1 month ago (2012-08-28 07:50:41 UTC) #3

Takashi Toyoshima

13 years, 1 month ago (2012-08-28 08:20:08 UTC) #4

tyoshino (chromium.org)

13 years, 1 month ago (2012-08-28 08:37:55 UTC) #5

LGTM

https://codereview.appspot.com/6491043/diff/1/src/mod_pywebsocket/standalone.py
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/6491043/diff/1/src/mod_pywebsocket/standalone....
src/mod_pywebsocket/standalone.py:423: if self.server_address[1] == 0:
On 2012/08/28 08:20:08, Takashi Toyoshima wrote:
> As the description and comments said, I intend that latter interfaces follow
the
> same port number with the first interface.

Please replace "interface" with "socket".

Expand All Messages | Collapse All Messages