Add SkBBoxRecord subclass that builds up a BBoxHierarchy and PictureStateTree.

Add SkBBoxRecord subclass that builds up a BBoxHierarchy and PictureStateTree.
Committed: https://code.google.com/p/skia/source/detail?r=5500

[rileya, 2012-09-11 17:01:38]

This one is pretty straightforward, it pretty much just calls through to all the
stuff from the last few CLs,

That said, I am a bit iffy on placing the BBoxHierarchy and PictureStateTree
pointers in PictureRecord... since they'll (currently) only ever be used by this
specific subclass.

Also, if anyone has a better name for this, it could probably be improved.

[reed1, 2012-09-11 17:42:50]

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.cpp
File src/core/SkBBoxHierarchyRecord.cpp (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.c...
src/core/SkBBoxHierarchyRecord.cpp:15: fStateTree = SkNEW(SkPictureStateTree);
Just checking: fBoundingHierarchy does not "own" h?

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.c...
src/core/SkBBoxHierarchyRecord.cpp:19: void
SkBBoxHierarchyRecord::handleBBox(const SkRect& bounds) {
bounds.roundOut(&r); ?

may want to experiment with using float rects everywhere, instead of int rects.

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.h
File src/core/SkBBoxHierarchyRecord.h (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.h...
src/core/SkBBoxHierarchyRecord.h:19: public:
// Comment: what is the ownership rule for h here? What should the caller know?

http://codereview.appspot.com/6490104/diff/1/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkPictureRecord.h#newco...
src/core/SkPictureRecord.h:169: 
// Comment: these are set to NULL in our constructor, but may be changed by
subclasses. If so, they will be safe-unref'd in our destructor.

[rileya, 2012-09-11 18:51:01]

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.cpp
File src/core/SkBBoxHierarchyRecord.cpp (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.c...
src/core/SkBBoxHierarchyRecord.cpp:15: fStateTree = SkNEW(SkPictureStateTree);
On 2012/09/11 17:42:51, reed1 wrote:
> Just checking: fBoundingHierarchy does not "own" h?

I made it take a ref.

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.c...
src/core/SkBBoxHierarchyRecord.cpp:19: void
SkBBoxHierarchyRecord::handleBBox(const SkRect& bounds) {
On 2012/09/11 17:42:51, reed1 wrote:
> bounds.roundOut(&r); ?
> 
> may want to experiment with using float rects everywhere, instead of int
rects.

Fixed, and if I have time I'll give float rects a try.

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.h
File src/core/SkBBoxHierarchyRecord.h (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkBBoxHierarchyRecord.h...
src/core/SkBBoxHierarchyRecord.h:19: public:
On 2012/09/11 17:42:51, reed1 wrote:
> // Comment: what is the ownership rule for h here? What should the caller
know?

Added a note about this.

http://codereview.appspot.com/6490104/diff/1/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

http://codereview.appspot.com/6490104/diff/1/src/core/SkPictureRecord.h#newco...
src/core/SkPictureRecord.h:169: 
On 2012/09/11 17:42:51, reed1 wrote:
> // Comment: these are set to NULL in our constructor, but may be changed by
> subclasses. If so, they will be safe-unref'd in our destructor.

Added.

[robertphillips, 2012-09-11 20:04:23]

lgtm + 1 question

http://codereview.appspot.com/6490104/diff/5001/src/core/SkBBoxHierarchyRecor...
File src/core/SkBBoxHierarchyRecord.cpp (right):

http://codereview.appspot.com/6490104/diff/5001/src/core/SkBBoxHierarchyRecor...
src/core/SkBBoxHierarchyRecord.cpp:22: bounds.roundOut(&r);
where is writeStream coming from - does it need a this-> or an INHERITED?

[rileya, 2012-09-11 20:22:08]

On 2012/09/11 20:04:23, robertphillips wrote:
> lgtm + 1 question
> 
>
http://codereview.appspot.com/6490104/diff/5001/src/core/SkBBoxHierarchyRecor...
> File src/core/SkBBoxHierarchyRecord.cpp (right):
> 
>
http://codereview.appspot.com/6490104/diff/5001/src/core/SkBBoxHierarchyRecor...
> src/core/SkBBoxHierarchyRecord.cpp:22: bounds.roundOut(&r);
> where is writeStream coming from - does it need a this-> or an INHERITED?

It's a non-virtual function on the grandparent class (SkPictureRecord), so I
added this->'s. Landed as r5500.