Fix HTTP 403 error on python 2.7

Fix HTTP 403 error on python 2.7

On python 2.7, urllib2.HTTPError.reason is a property and not a variable, so assignment is disallowed. Commenting out the line works just fine.

[Andi, 2012-09-03 16:08:32]

Adding Guido since I'm not very familiar with Google's authentication mechanism.


In AbstractRpcServer._GetAuthToken() we're reading the body of the response from
the authentication server and passing the information to ClientLoginError where
we set "reason". In AbstractRpcServer._Authenticate() we handle the information
in "reason" again. But since you say it works fine I assume that reason already
has this bit of information we need in _Authenticate()?

[M-A, 2012-09-03 16:44:08]

On 2012/09/03 16:08:32, Andi wrote:
> Adding Guido since I'm not very familiar with Google's authentication
mechanism.
> 
> 
> In AbstractRpcServer._GetAuthToken() we're reading the body of the response
from
> the authentication server and passing the information to ClientLoginError
where
> we set "reason". In AbstractRpcServer._Authenticate() we handle the
information
> in "reason" again. But since you say it works fine I assume that reason
already
> has this bit of information we need in _Authenticate()?

You are right. I looked at python 2.6's version and reason is set for URLError
but not HTTPError. So the one-size-fits-all fix is to use a property, so it'll
work on both versions.

[gvrpython, 2012-09-04 07:02:24]

I'm confused. Where in the Python 2.7 stdlib is reason made a property?

On Mon, Sep 3, 2012 at 6:44 PM,  <maruel@chromium.org> wrote:
> On 2012/09/03 16:08:32, Andi wrote:
>>
>> Adding Guido since I'm not very familiar with Google's authentication
>
> mechanism.
>
>
>> In AbstractRpcServer._GetAuthToken() we're reading the body of the
>
> response from
>>
>> the authentication server and passing the information to
>
> ClientLoginError where
>>
>> we set "reason". In AbstractRpcServer._Authenticate() we handle the
>
> information
>>
>> in "reason" again. But since you say it works fine I assume that
>
> reason already
>>
>> has this bit of information we need in _Authenticate()?
>
>
> You are right. I looked at python 2.6's version and reason is set for
> URLError but not HTTPError. So the one-size-fits-all fix is to use a
> property, so it'll work on both versions.
>
> https://codereview.appspot.com/6490072/



-- 
--Guido van Rossum (python.org/~guido)

[Andi, 2012-09-04 07:09:31]

It seems to be this issue: http://bugs.python.org/issue13211

--
Andi

On Tue, Sep 4, 2012 at 9:02 AM, Guido van Rossum <guido@python.org> wrote:
> I'm confused. Where in the Python 2.7 stdlib is reason made a property?
>
> On Mon, Sep 3, 2012 at 6:44 PM,  <maruel@chromium.org> wrote:
>> On 2012/09/03 16:08:32, Andi wrote:
>>>
>>> Adding Guido since I'm not very familiar with Google's authentication
>>
>> mechanism.
>>
>>
>>> In AbstractRpcServer._GetAuthToken() we're reading the body of the
>>
>> response from
>>>
>>> the authentication server and passing the information to
>>
>> ClientLoginError where
>>>
>>> we set "reason". In AbstractRpcServer._Authenticate() we handle the
>>
>> information
>>>
>>> in "reason" again. But since you say it works fine I assume that
>>
>> reason already
>>>
>>> has this bit of information we need in _Authenticate()?
>>
>>
>> You are right. I looked at python 2.6's version and reason is set for
>> URLError but not HTTPError. So the one-size-fits-all fix is to use a
>> property, so it'll work on both versions.
>>
>> https://codereview.appspot.com/6490072/
>
>
>
> --
> --Guido van Rossum (python.org/~guido)

[gvrpython, 2012-09-04 09:23:03]

Gotcha. LGTM!

On Tue, Sep 4, 2012 at 9:09 AM, Andi Albrecht <albrecht.andi@gmail.com> wrote:
> It seems to be this issue: http://bugs.python.org/issue13211
>
> --
> Andi
>
> On Tue, Sep 4, 2012 at 9:02 AM, Guido van Rossum <guido@python.org> wrote:
>> I'm confused. Where in the Python 2.7 stdlib is reason made a property?
>>
>> On Mon, Sep 3, 2012 at 6:44 PM,  <maruel@chromium.org> wrote:
>>> On 2012/09/03 16:08:32, Andi wrote:
>>>>
>>>> Adding Guido since I'm not very familiar with Google's authentication
>>>
>>> mechanism.
>>>
>>>
>>>> In AbstractRpcServer._GetAuthToken() we're reading the body of the
>>>
>>> response from
>>>>
>>>> the authentication server and passing the information to
>>>
>>> ClientLoginError where
>>>>
>>>> we set "reason". In AbstractRpcServer._Authenticate() we handle the
>>>
>>> information
>>>>
>>>> in "reason" again. But since you say it works fine I assume that
>>>
>>> reason already
>>>>
>>>> has this bit of information we need in _Authenticate()?
>>>
>>>
>>> You are right. I looked at python 2.6's version and reason is set for
>>> URLError but not HTTPError. So the one-size-fits-all fix is to use a
>>> property, so it'll work on both versions.
>>>
>>> https://codereview.appspot.com/6490072/
>>
>>
>>
>> --
>> --Guido van Rossum (python.org/~guido)



-- 
--Guido van Rossum (python.org/~guido)

[Andi, 2012-09-04 09:46:20]

oh, I didn't notice the new changeset. LGTM too!