Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6490044: Raise if cert checking is on but txaws is too old

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by gz
Modified:
13 years, 6 months ago
Reviewers:
jimbaker, mp+121660
Visibility:
Public.

Description

Raise if cert checking is on but txaws is too old As requested by Jim in review for the openstack https cert branch, setting ssl-hostname-validation on when txaws is too old to have the support will now raise an error with this branch, rather than giving a warning then treating it as false. The error message encourages either upgrading txaws or making the config reflect reality. As this is a reasonable behaviour, the EC2 provider is also changed to do the same thing in this one case. https://code.launchpad.net/~gz/juju/old_txaws_refuse_check_certs/+merge/121660 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -33 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/errors.py View 1 chunk +9 lines, -0 lines 0 comments Download
M juju/providers/ec2/__init__.py View 3 chunks +7 lines, -9 lines 0 comments Download
M juju/providers/ec2/tests/test_provider.py View 3 chunks +23 lines, -16 lines 0 comments Download
M juju/providers/openstack/client.py View 1 chunk +1 line, -3 lines 0 comments Download
M juju/providers/openstack/tests/test_provider.py View 2 chunks +3 lines, -4 lines 0 comments Download
M juju/tests/test_errors.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
13 years, 6 months ago (2012-08-28 16:18:55 UTC) #1
jimbaker
13 years, 6 months ago (2012-08-28 17:46:35 UTC) #2
+1, LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b