Make BBoxHierarchy ref-counted, fix leak in RTreeTest.

Make BBoxHierarchy ref-counted, fix leak in RTreeTest.
Committed: https://code.google.com/p/skia/source/detail?r=5484

[rileya, 2012-09-11 12:24:07]

http://codereview.appspot.com/6500101/ reminded me that I should make the RTree
ref-counted, also fixed a minor leak in the RTree test.

[reed1, 2012-09-11 12:28:25]

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h
File src/core/SkBBoxHierarchy.h (right):

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h#newco...
src/core/SkBBoxHierarchy.h:22: virtual ~SkBBoxHierarchy() { }
Don't need this empty destructor, now that you inherit from something (that
already has one)

http://codereview.appspot.com/6489108/diff/1/tests/RTreeTest.cpp
File tests/RTreeTest.cpp (right):

http://codereview.appspot.com/6489108/diff/1/tests/RTreeTest.cpp#newcode86
tests/RTreeTest.cpp:86: 
Option: replace the last rtree->unref() with

SkAutoUnref au(rtree);

here.

[robertphillips, 2012-09-11 12:30:24]

Should SkPicture be getting a ref somewhere?

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h
File src/core/SkBBoxHierarchy.h (right):

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h#newco...
src/core/SkBBoxHierarchy.h:19: */
Add INHERITED & instance counting stuff

[rileya, 2012-09-11 13:35:24]

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h
File src/core/SkBBoxHierarchy.h (right):

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h#newco...
src/core/SkBBoxHierarchy.h:19: */
On 2012/09/11 12:30:24, robertphillips wrote:
> Add INHERITED & instance counting stuff

Done.

http://codereview.appspot.com/6489108/diff/1/src/core/SkBBoxHierarchy.h#newco...
src/core/SkBBoxHierarchy.h:22: virtual ~SkBBoxHierarchy() { }
On 2012/09/11 12:28:26, reed1 wrote:
> Don't need this empty destructor, now that you inherit from something (that
> already has one)
Removed.

http://codereview.appspot.com/6489108/diff/1/tests/RTreeTest.cpp
File tests/RTreeTest.cpp (right):

http://codereview.appspot.com/6489108/diff/1/tests/RTreeTest.cpp#newcode86
tests/RTreeTest.cpp:86: 
On 2012/09/11 12:28:26, reed1 wrote:
> Option: replace the last rtree->unref() with
> 
> SkAutoUnref au(rtree);
> 
> here.

Done.

[rileya, 2012-09-11 15:19:40]

Any more thoughts? My next CL is blocked on this.

[reed1, 2012-09-11 15:21:12]

DWOM (don't wait on me)

[bsalomon, 2012-09-11 15:32:32]

On 2012/09/11 15:21:12, reed1 wrote:
> DWOM (don't wait on me)

LGTM