Issue 6489102: Add optional aspect ratio parameter to R-Tree, this helps the bulk load algorithm create more squar…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489102: Add optional aspect ratio parameter to R-Tree, this helps the bulk load algorithm create more squar… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rileya

Modified:
12 years, 2 months ago

Reviewers:
bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add optional aspect ratio parameter to R-Tree, this helps the bulk load algorithm create more square tiles. Committed: https://code.google.com/p/skia/source/detail?r=5466

Patch Set 1 #

Patch Set 2 : add a line break. #

Patch Set 3 : add comment about aspect ratio param. #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	src/core/SkRTree.h	View	1 2	3 chunks	+6 lines, -2 lines	0 comments	Download
	M	src/core/SkRTree.cpp	View	1	3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

12 years, 2 months ago (2012-09-10 17:17:04 UTC) #2

On 2012/09/10 16:53:00, rileya wrote:

LGTM (but could you add a comment to the .h about the aspect ratio).

Expand All Messages | Collapse All Messages