Issue 6489085: Resource cache now explicitly takes ref of managed resources

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489085: Resource cache now explicitly takes ref of managed resources (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL changes the resource cache to explicitly ref the owned resources rather than just absorbing outside refs. Not sure if it is really any clearer.

Patch Set 1 #

Patch Set 2 : Moved ref into GrResourceEntry ctor #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	src/gpu/GrContext.cpp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrStencilBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

committed as r5407

Expand All Messages | Collapse All Messages