Issue 6489045: Fix Clang build on Android.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489045: Fix Clang build on Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by digit1

Modified:
11 years, 10 months ago

Reviewers:
pliard1, DerekS, caryclark1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix Clang build on Android. The optimize attribute is not supported with Clang/ARM r161757. This warning, turned into an error, is emitted by -Wattribute (implicitly set). Committed: https://code.google.com/p/skia/source/detail?r=5316

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	include/core/SkPreConfig.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
	M	src/opts/SkBitmapProcState_opts_arm.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

caryclark1

https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp File src/opts/SkBitmapProcState_opts_arm.cpp (right): https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp#newcode12 src/opts/SkBitmapProcState_opts_arm.cpp:12: #include "SkPreConfig.h" SkPreConfig is always included by all Sk ...

11 years, 10 months ago (2012-08-28 14:06:28 UTC) #2

digit1

11 years, 10 months ago (2012-08-28 14:13:10 UTC) #3

lgtm

Expand All Messages | Collapse All Messages