Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1583)

Issue 6489045: Fix Clang build on Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by digit1
Modified:
12 years, 2 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix Clang build on Android. The optimize attribute is not supported with Clang/ARM r161757. This warning, turned into an error, is emitted by -Wattribute (implicitly set). Committed: https://code.google.com/p/skia/source/detail?r=5316

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +27 lines, -0 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
digit1
Patch original from pliard@chromium.org
12 years, 2 months ago (2012-08-28 13:53:18 UTC) #1
caryclark1
https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp File src/opts/SkBitmapProcState_opts_arm.cpp (right): https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp#newcode12 src/opts/SkBitmapProcState_opts_arm.cpp:12: #include "SkPreConfig.h" SkPreConfig is always included by all Sk ...
12 years, 2 months ago (2012-08-28 14:06:28 UTC) #2
digit1
https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp File src/opts/SkBitmapProcState_opts_arm.cpp (right): https://codereview.appspot.com/6489045/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp#newcode12 src/opts/SkBitmapProcState_opts_arm.cpp:12: #include "SkPreConfig.h" On 2012/08/28 14:06:29, caryclark1 wrote: > SkPreConfig ...
12 years, 2 months ago (2012-08-28 14:13:10 UTC) #3
caryclark1
12 years, 2 months ago (2012-08-28 14:56:46 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b