Issue 6488114: Fix buildbot arguments to bench after https://codereview.appspot.com/6500108/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488114: Fix buildbot arguments to bench after https://codereview.appspot.com/6500108/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by EricB

Modified:
11 years, 9 months ago

Reviewers:
epoger, Leon, rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/buildbot/

Visibility:
Public.

More Reviews

Description

Fix buildbot arguments to bench after https://codereview.appspot.com/6500108/ Committed: https://code.google.com/p/skia/source/detail?r=5514

Patch Set 2 : #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
M	master/master_builders_cfg.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	slave/skia_slave_scripts/bench_pictures.py	View	1	1 chunk	+0 lines, -3 lines	2 comments	Download
M	slave/skia_slave_scripts/run_bench.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

LGTM at patchset 2, assuming one thing... https://codereview.appspot.com/6488114/diff/2001/slave/skia_slave_scripts/bench_pictures.py File slave/skia_slave_scripts/bench_pictures.py (left): https://codereview.appspot.com/6488114/diff/2001/slave/skia_slave_scripts/bench_pictures.py#oldcode15 slave/skia_slave_scripts/bench_pictures.py:15: def _BuildArgs(self, ...

11 years, 9 months ago (2012-09-12 14:52:39 UTC) #2

EricB

11 years, 9 months ago (2012-09-12 19:14:30 UTC) #3

https://codereview.appspot.com/6488114/diff/2001/slave/skia_slave_scripts/ben...
File slave/skia_slave_scripts/bench_pictures.py (left):

https://codereview.appspot.com/6488114/diff/2001/slave/skia_slave_scripts/ben...
slave/skia_slave_scripts/bench_pictures.py:15: def _BuildArgs(self, repeats,
data_file):
On 2012/09/12 14:52:39, epoger wrote:
> I guess you know what you're doing removing this (it seems like a bit of a
> different change than the rest of this CL)

Yep.  Since bench_pictures now supports the same arguments as bench, and since
we want to run with the same settings, we'll provide the same set of arguments.

Expand All Messages | Collapse All Messages