Issue 6488100: Add some untracked directories to gitignore.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488100: Add some untracked directories to gitignore. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by tfarina1

Modified:
11 years, 12 months ago

Reviewers:
epoger, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add some untracked directories to gitignore. Now the output of 'git status' is clean: nothing to commit (working directory clean) Signed-off-by: Thiago Farina <tfarina@chromium.org>

Patch Set 2 : ignore all externals #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	A	.gitignore	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

epoger

LGTM https://codereview.appspot.com/6488100/diff/1/.gitignore File .gitignore (right): https://codereview.appspot.com/6488100/diff/1/.gitignore#newcode2 .gitignore:2: /third_party/externals/angle/ You should be able to ignore all ...

11 years, 12 months ago (2012-09-11 19:33:03 UTC) #3

tfarina1

Could you land this to me? I don't have commit rights. https://codereview.appspot.com/6488100/diff/1/.gitignore File .gitignore (right): ...

11 years, 12 months ago (2012-09-12 01:01:52 UTC) #4

epoger

11 years, 12 months ago (2012-09-12 15:04:22 UTC) #5

Landed as https://code.google.com/p/skia/source/detail?r=5507 , using the steps
at
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...

Thanks, Thiago!

Expand All Messages | Collapse All Messages