Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(648)

Issue 6488100: Add some untracked directories to gitignore. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by tfarina1
Modified:
12 years, 3 months ago
Reviewers:
epoger, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add some untracked directories to gitignore. Now the output of 'git status' is clean: nothing to commit (working directory clean) Signed-off-by: Thiago Farina <tfarina@chromium.org>

Patch Set 1 #

Total comments: 2

Patch Set 2 : ignore all externals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A .gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
tfarina1
Please, take a look. Thanks.
12 years, 3 months ago (2012-09-08 01:48:11 UTC) #1
tfarina1
+Elliot for review!
12 years, 3 months ago (2012-09-11 02:17:28 UTC) #2
epoger
LGTM https://codereview.appspot.com/6488100/diff/1/.gitignore File .gitignore (right): https://codereview.appspot.com/6488100/diff/1/.gitignore#newcode2 .gitignore:2: /third_party/externals/angle/ You should be able to ignore all ...
12 years, 3 months ago (2012-09-11 19:33:03 UTC) #3
tfarina1
Could you land this to me? I don't have commit rights. https://codereview.appspot.com/6488100/diff/1/.gitignore File .gitignore (right): ...
12 years, 3 months ago (2012-09-12 01:01:52 UTC) #4
epoger
12 years, 3 months ago (2012-09-12 15:04:22 UTC) #5

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b