Issue 6488098: Removed old resource locking system

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488098: Removed old resource locking system (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by robertphillips

Modified:
11 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Cache behavior appears equivalent in the new version: __OLD__ tests Budget: 256 items 16777216 bytes Entry Count: current 13 high 13 Unlocked Entry Count: current 12 high 12 Entry Bytes: current 1794384 high 1794384 Detached Entry Count: current 0 high 2 Detached Bytes: current 0 high 524288 gm config: gpu 42e730 Budget: 256 items 16777216 bytes Entry Count: current 12 high 163 Unlocked Entry Count: current 12 high 162 Entry Bytes: current 16750800 high 216988800 Detached Entry Count: current 0 high 13 Detached Bytes: current 0 high 14133056 __NEW__ tests Budget: 256 items 16777216 bytes Entry Count: current 13 (1 locked) high 13 Entry Bytes: current 1794384 high 1794384 Detached Entry Count: current 0 high 2 Detached Bytes: current 0 high 524288 gm config: gpu 315738 Budget: 256 items 16777216 bytes Entry Count: current 8 (0 locked) high 163 Entry Bytes: current 14968800 high 216988800 Detached Entry Count: current 0 high 13 Detached Bytes: current 0 high 14133056

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -215 lines)			Patch
M	include/gpu/GrContext.h	View	6 chunks	+15 lines, -22 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	9 chunks	+17 lines, -46 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrRenderTarget.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	6 chunks	+4 lines, -34 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	15 chunks	+25 lines, -90 lines	0 comments	Download
M	src/gpu/GrStencilBuffer.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/GrStencilBuffer.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	4 chunks	+9 lines, -8 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrTextureStripAtlas.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

committed as r5453

Expand All Messages | Collapse All Messages