code review 6487043: go.crypto/ssh: fix test failure on windows

go.crypto/ssh: fix test failure on windows

Use a handler that does not attempt to send a status message
as the failing test closes the connection abruptly.

Also, check the err response on all shell.ReadLine operations.

[dave_cheney.net, 2012-08-25 05:33:32]

Hello agl@golang.org, minux.ma@gmail.com, kardianos@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[kardia, 2012-08-25 06:29:43]

I can confirm this makes tests pass on Windows. Changes look benign.

[dave_cheney.net, 2012-08-25 06:30:33]

On 2012/08/25 06:29:43, kardia wrote:
> I can confirm this makes tests pass on Windows. Changes look benign.

Thank you. Can you confirm before this CL the test was failing on your windows
host ?

[kardia, 2012-08-25 06:34:28]

On Sat, 25 Aug 2012 06:30:33 +0000
dave@cheney.net wrote:

> On 2012/08/25 06:29:43, kardia wrote:
> > I can confirm this makes tests pass on Windows. Changes look benign.
> 
> Thank you. Can you confirm before this CL the test was failing on your
> windows host ?
> 
> http://codereview.appspot.com/6487043/

Yes. Before it was failing, with the patch it passed.
Windows 7, x64

-Daniel

[minux1, 2012-08-25 07:02:06]

w/o this CL test fails on windows/386 with a probability of about 1/2.
after applying this CL, i ran the test for 20 times without seeing any failure,
so i'm reasonably sure this fixed the test.

[dave_cheney.net, 2012-08-25 07:07:22]

Thank you. I will submit soon. 

On 25/08/2012, at 17:02, minux.ma@gmail.com wrote:

> w/o this CL test fails on windows/386 with a probability of about 1/2.
> after applying this CL, i ran the test for 20 times without seeing any
> failure,
> so i'm reasonably sure this fixed the test.
> 
> http://codereview.appspot.com/6487043/

[dave_cheney.net, 2012-08-25 07:53:05]

*** Submitted as
http://code.google.com/p/go/source/detail?r=87f3ce85c32a&repo=crypto ***

go.crypto/ssh: fix test failure on windows

Use a handler that does not attempt to send a status message
as the failing test closes the connection abruptly.

Also, check the err response on all shell.ReadLine operations.

R=agl, minux.ma, kardianos
CC=golang-dev
http://codereview.appspot.com/6487043