Issue 6486065: Default ssl-hostname-verification on for openstack provider

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6486065: Default ssl-hostname-verification on for openstack provider

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by gz

Modified:
13 years, 6 months ago

Reviewers:
jimbaker, mp+121267

Visibility:
Public.

Description

Default ssl-hostname-verification on for openstack provider As discussed in prereq merge proposal and on irc, consensus is that juju should check HTTPS certificates by default, even if the EC2 behaviour can't be changed for precise. This branch treats the config value as True if it is not specified. https://code.launchpad.net/~gz/juju/os_check_certs_default/+merge/121267 Requires: https://code.launchpad.net/~gz/juju/os_https_certs_1026102/+merge/118602 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/openstack/provider.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/openstack/tests/__init__.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/openstack/tests/test_provider.py	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jimbaker

13 years, 6 months ago (2012-08-24 21:09:56 UTC) #2

On 2012/08/24 19:31:37, gz wrote:
> Please take a look.

+1, LGTM

Expand All Messages | Collapse All Messages