Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)

Issue 6485061: Implement D3DConstantTable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by apatrick1
Modified:
12 years, 11 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Implement D3DConstantTable. Remove ProgramBinary dependencies on D3DX. Committed: https://code.google.com/p/angleproject/source/detail?r=1271

Patch Set 1 : #

Total comments: 27

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -129 lines) Patch
M src/common/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/BinaryStream.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A src/libGLESv2/D3DConstantTable.h View 1 1 chunk +116 lines, -0 lines 0 comments Download
A src/libGLESv2/D3DConstantTable.cpp View 1 2 1 chunk +231 lines, -0 lines 0 comments Download
M src/libGLESv2/Program.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/libGLESv2/ProgramBinary.h View 1 2 4 chunks +18 lines, -17 lines 1 comment Download
M src/libGLESv2/ProgramBinary.cpp View 1 2 16 chunks +81 lines, -109 lines 0 comments Download
M src/libGLESv2/Shader.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/libGLESv2/libGLESv2.vcproj View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/libGLESv2/mathutil.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7
apatrick1
Daniel, No regressions with WebGL conformance tests. I also tested shader toy which has some ...
13 years ago (2012-08-24 20:18:04 UTC) #1
dgkoch
Does this have the structure fix that we noted was necessary in the other issue? ...
12 years, 12 months ago (2012-08-29 03:41:15 UTC) #2
apatrick1
I ran the WebGL conformance tests again. Still okay. PTAL. https://codereview.appspot.com/6485061/diff/8/src/libGLESv2/Context.cpp File src/libGLESv2/Context.cpp (right): https://codereview.appspot.com/6485061/diff/8/src/libGLESv2/Context.cpp#newcode12 ...
12 years, 12 months ago (2012-08-31 19:52:37 UTC) #3
nicolas
Looks great to me. Only one tiny comment. https://codereview.appspot.com/6485061/diff/16001/src/libGLESv2/ProgramBinary.cpp File src/libGLESv2/ProgramBinary.cpp (right): https://codereview.appspot.com/6485061/diff/16001/src/libGLESv2/ProgramBinary.cpp#newcode113 src/libGLESv2/ProgramBinary.cpp:113: delete ...
12 years, 11 months ago (2012-09-04 19:14:38 UTC) #4
dgkoch
LGTM (after noted fixes). Great work! https://codereview.appspot.com/6485061/diff/8/src/libGLESv2/Context.cpp File src/libGLESv2/Context.cpp (right): https://codereview.appspot.com/6485061/diff/8/src/libGLESv2/Context.cpp#newcode12 src/libGLESv2/Context.cpp:12: #include <d3dx9.h> On ...
12 years, 11 months ago (2012-09-04 20:37:44 UTC) #5
dgkoch
On 2012/08/31 19:52:37, apatrick1 wrote: > I ran the WebGL conformance tests again. Still okay. ...
12 years, 11 months ago (2012-09-04 20:39:17 UTC) #6
apatrick1
12 years, 11 months ago (2012-09-05 22:09:56 UTC) #7
No WebGL conformance test regressions in Firefox 15. I did find an issue in
debug builds though...

https://codereview.appspot.com/6485061/diff/20010/src/libGLESv2/ProgramBinary.h
File src/libGLESv2/ProgramBinary.h (left):

https://codereview.appspot.com/6485061/diff/20010/src/libGLESv2/ProgramBinary...
src/libGLESv2/ProgramBinary.h:67: ASSERT(registerCount == 0 || registerCount ==
(int)constantDescription.RegisterCount);
...here
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b