Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 6483045: Avoid storing references to temporary strings in RenameFunction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by mvujovic
Modified:
13 years ago
Reviewers:
dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Avoid storing references to temporary strings in RenameFunction The RenameFunction constructor is called like this: void TCompiler::rewriteCSSShader(TIntermNode* root) { RenameFunction renamer("main(", "css_main("); root->traverse(&renamer); } So, "main(" and "css_main(" become temporary TStrings, which RenameFunction holds on to. It should copy them instead. Issue: http://code.google.com/p/angleproject/issues/detail?id=360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/RenameFunction.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mvujovic
Hi guys, Could you review this small fix when you get a chance? Thanks, Max
13 years ago (2012-08-22 21:14:25 UTC) #1
dgkoch
LGTM
13 years ago (2012-08-27 17:45:54 UTC) #2
mvujovic
13 years ago (2012-08-27 20:48:53 UTC) #3
On 2012/08/27 17:45:54, dgkoch wrote:
> LGTM

Committed in r1266. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b