Issue 6481066: Script to help cycle skia-autogen (Closed)
|
Created:
12 years, 4 months ago by EricB Modified:
12 years, 4 months ago CC:
skia-review_googlegroups.com Base URL:
http://skia.googlecode.com/svn/trunk/ Visibility:
Public. |
DescriptionScript to help cycle skia-autogen
Committed: https://code.google.com/p/skia/source/detail?r=5291
Patch Set 1 #Patch Set 2 : #
Total comments: 6
Patch Set 3 : #MessagesTotal messages: 10
This script should probably take some of the constants as parameters.
Sign in to reply to this message.
nice! a couple small suggestions. https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh File tools/roll_autogen.sh (right): https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode1 tools/roll_autogen.sh:1: #/bin/bash Please add comments at the top indicating what this script does. https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode3 tools/roll_autogen.sh:3: REPO="https://skia-autogen.googlecode.com/svn" One option to allow the user to override these default values is... REPO=${REPO:-https://skia-autogen.googlecode.com/svn} Then the user can override like so: REPO=https://my.domain/svn roll_autogen.sh ...or... export REPO=https://my.domain/svn roll_autogen.sh See https://code.google.com/p/skia/source/browse/trunk/tools/update-doxygen.sh https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode38 tools/roll_autogen.sh:38: echo "Now you need to reset the remote repository (${REPO}). Please do so and press any key to continue." maybe include the URL at which the reset button can be found?
Sign in to reply to this message.
Uploaded Patch Set 3. Ravi, what needs to be done so that the Doxygen bot will be happy? https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh File tools/roll_autogen.sh (right): https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode1 tools/roll_autogen.sh:1: #/bin/bash On 2012/08/27 17:24:38, epoger wrote: > Please add comments at the top indicating what this script does. Done. https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode3 tools/roll_autogen.sh:3: REPO="https://skia-autogen.googlecode.com/svn" On 2012/08/27 17:24:38, epoger wrote: > One option to allow the user to override these default values is... > > REPO=${REPO:-https://skia-autogen.googlecode.com/svn} > > Then the user can override like so: > > REPO=https://my.domain/svn roll_autogen.sh > ...or... > export REPO=https://my.domain/svn > roll_autogen.sh > > > See https://code.google.com/p/skia/source/browse/trunk/tools/update-doxygen.sh Done. https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode38 tools/roll_autogen.sh:38: echo "Now you need to reset the remote repository (${REPO}). Please do so and press any key to continue." On 2012/08/27 17:24:38, epoger wrote: > maybe include the URL at which the reset button can be found? Done.
Sign in to reply to this message.
On 2012/08/27 17:50:14, EricB wrote: > Uploaded Patch Set 3. Ravi, what needs to be done so that the Doxygen bot will > be happy? We need to add iframe_footer.html and static_footer.txt from http://code.google.com/p/skia-autogen/source/browse/#svn%2Fdocs to the docs directory. > > https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh > File tools/roll_autogen.sh (right): > > https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode1 > tools/roll_autogen.sh:1: #/bin/bash > On 2012/08/27 17:24:38, epoger wrote: > > Please add comments at the top indicating what this script does. > > Done. > > https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode3 > tools/roll_autogen.sh:3: REPO="https://skia-autogen.googlecode.com/svn" > On 2012/08/27 17:24:38, epoger wrote: > > One option to allow the user to override these default values is... > > > > REPO=${REPO:-https://skia-autogen.googlecode.com/svn} > > > > Then the user can override like so: > > > > REPO=https://my.domain/svn roll_autogen.sh > > ...or... > > export REPO=https://my.domain/svn > > roll_autogen.sh > > > > > > See https://code.google.com/p/skia/source/browse/trunk/tools/update-doxygen.sh > > Done. > > https://codereview.appspot.com/6481066/diff/2001/tools/roll_autogen.sh#newcode38 > tools/roll_autogen.sh:38: echo "Now you need to reset the remote repository > (${REPO}). Please do so and press any key to continue." > On 2012/08/27 17:24:38, epoger wrote: > > maybe include the URL at which the reset button can be found? > > Done.
Sign in to reply to this message.
LGTM at patchset 3 (I know that the doxygen stuff still needs to be added...)
Sign in to reply to this message.
On 2012/08/27 17:53:37, rmistry wrote: > On 2012/08/27 17:50:14, EricB wrote: > > Uploaded Patch Set 3. Ravi, what needs to be done so that the Doxygen bot > will > > be happy? > > We need to add iframe_footer.html and static_footer.txt from > http://code.google.com/p/skia-autogen/source/browse/#svn%252Fdocs to the docs > directory. Excuse my ignorance, but these files are generated by Doxygen? If so, what command-line should I use to produce them?
Sign in to reply to this message.
I dont think they are generated by Doxygen but they are (well static_footer.txt is) referred to in http://code.google.com/p/skia/source/browse/trunk/Doxyfile. I do not know how they were first generated, I loaded a previous revision of skia-autogen repository and grabbed the files from there after the repo was reset. On Mon, Aug 27, 2012 at 2:01 PM, <borenet@google.com> wrote: > On 2012/08/27 17:53:37, rmistry wrote: > >> On 2012/08/27 17:50:14, EricB wrote: >> > Uploaded Patch Set 3. Ravi, what needs to be done so that the >> > Doxygen bot > >> will >> > be happy? >> > > We need to add iframe_footer.html and static_footer.txt from >> http://code.google.com/p/skia-**autogen/source/browse/#svn%**252Fdocs<http://... >> > the docs > >> directory. >> > > Excuse my ignorance, but these files are generated by Doxygen? If so, > what command-line should I use to produce them? > > http://codereview.appspot.com/**6481066/<http://codereview.appspot.com/6481066/> >
Sign in to reply to this message.
On 2012/08/27 18:05:14, rmistry wrote: > I dont think they are generated by Doxygen but they are (well > static_footer.txt is) referred to in > http://code.google.com/p/skia/source/browse/trunk/Doxyfile. > I do not know how they were first generated, I loaded a previous revision > of skia-autogen repository and grabbed the files from there after the repo > was reset. > > > On Mon, Aug 27, 2012 at 2:01 PM, <mailto:borenet@google.com> wrote: > > > On 2012/08/27 17:53:37, rmistry wrote: > > > >> On 2012/08/27 17:50:14, EricB wrote: > >> > Uploaded Patch Set 3. Ravi, what needs to be done so that the > >> > > Doxygen bot > > > >> will > >> > be happy? > >> > > > > We need to add iframe_footer.html and static_footer.txt from > >> > http://code.google.com/p/skia-**autogen/source/browse/#svn%25**252Fdocs%3Chtt... > >> > > the docs > > > >> directory. > >> > > > > Excuse my ignorance, but these files are generated by Doxygen? If so, > > what command-line should I use to produce them? > > > > > http://codereview.appspot.com/**6481066/%3Chttp://codereview.appspot.com/6481...> > > Actually, now that I think about it, since this script allows us to maintain the repository's state when we reset, those files should exist. I don't think it'll be a problem at all.
Sign in to reply to this message.
|
