Issue 6480052: tests: add engine-switch test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6480052: tests: add engine-switch test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Daiki Ueno

Modified:
13 years, 5 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

tests: add engine-switch test Moved engine specific test from ibus-bus.c to a separate file, so that it can be conditionally built depending on --enable-engine. Also do not register duplicate engine when loading component files. This is for the case when two engine descs with the same name are in different directories in IBUS_COMPONENT_PATH. BUG=none

Patch Set 1 #

Total comments: 5

Patch Set 2 : add log message when duplicate engine is found, check if global-engine-changed signal is emitted #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -25 lines)			Patch
M	bus/registry.c	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download
M	src/tests/Makefile.am	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	src/tests/ibus-bus.c	View		2 chunks	+0 lines, -21 lines	0 comments	Download
A	src/tests/ibus-engine-switch.c	View	1	1 chunk	+204 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6480052/diff/1/bus/registry.c File bus/registry.c (right): https://codereview.appspot.com/6480052/diff/1/bus/registry.c#newcode151 bus/registry.c:151: if (g_hash_table_lookup (registry->engine_table, name) == NULL) Maybe print warning ...

13 years, 5 months ago (2012-08-23 12:02:06 UTC) #2

Daiki Ueno

13 years, 5 months ago (2012-08-24 02:09:21 UTC) #3

Peng

13 years, 5 months ago (2012-08-24 12:14:39 UTC) #4

Lgtm with a comment

https://codereview.appspot.com/6480052/diff/1/bus/registry.c
File bus/registry.c (right):

https://codereview.appspot.com/6480052/diff/1/bus/registry.c#newcode151
bus/registry.c:151: if (g_hash_table_lookup (registry->engine_table, name) ==
NULL)
you could use g_message .
On 2012/08/24 02:09:21, Daiki Ueno wrote:
> On 2012/08/23 12:02:06, Peng wrote:
> > Maybe print warning log? I think it is useful for debug.
> 
> Done.  Used g_log() instead of g_warning() since it is not critical.

Expand All Messages | Collapse All Messages