SkBitmap::scrollRect changes pixels, but only if not immutable.

SkBitmap::scrollRect changes pixels, but only if not immutable.

scrollRect will now return false if the bitmap is immutable, and
call notifyPixelsChanged when changing the pixels. This will give
the bitmap a new generation ID.

Committed: https://code.google.com/p/skia/source/detail?r=5230

[DerekS, 2012-08-22 16:11:29]

lgtm with one nit.

https://codereview.appspot.com/6480046/diff/1/src/core/SkBitmap_scroll.cpp
File src/core/SkBitmap_scroll.cpp (right):

https://codereview.appspot.com/6480046/diff/1/src/core/SkBitmap_scroll.cpp#ne...
src/core/SkBitmap_scroll.cpp:83: this->notifyPixelsChanged();
I know it probably doesn't make a difference but logically it seems that we
should notify that we changed the pixels after we changed them and not before.

[Leon, 2012-08-22 16:19:27]

https://codereview.appspot.com/6480046/diff/1/src/core/SkBitmap_scroll.cpp
File src/core/SkBitmap_scroll.cpp (right):

https://codereview.appspot.com/6480046/diff/1/src/core/SkBitmap_scroll.cpp#ne...
src/core/SkBitmap_scroll.cpp:83: this->notifyPixelsChanged();
On 2012/08/22 16:11:30, DerekS wrote:
> I know it probably doesn't make a difference but logically it seems that we
> should notify that we changed the pixels after we changed them and not before.

Done.