Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3153)

Issue 6476072: The UBFX instruction isn't available on ARMv6; use LSL/LSR or UXTB. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by gw280
Modified:
12 years, 2 months ago
Reviewers:
EricB, DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

The UBFX instruction isn't available on ARMv6; use LSL/LSR or UXTB. Committed: https://code.google.com/p/skia/source/detail?r=5349

Patch Set 1 #

Patch Set 2 : Use UXTB in both cases where it's just an 8-bit extraction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/opts/SkBlitRow_opts_arm.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6
gw280
12 years, 2 months ago (2012-08-27 21:17:34 UTC) #1
reed1
Do our android bots exercise ARM6 and not-ARM6, so we can feel confident about this?
12 years, 2 months ago (2012-08-28 11:45:22 UTC) #2
EricB
On 2012/08/28 11:45:22, reed1 wrote: > Do our android bots exercise ARM6 and not-ARM6, so ...
12 years, 2 months ago (2012-08-28 12:00:03 UTC) #3
gw280
On 2012/08/28 12:00:03, EricB wrote: > On 2012/08/28 11:45:22, reed1 wrote: > > Do our ...
12 years, 2 months ago (2012-08-28 15:59:49 UTC) #4
gw280
I just ran the full GM suite with -march=armv6 on my Galaxy Nexus with --nopdf ...
12 years, 2 months ago (2012-08-28 19:45:18 UTC) #5
DerekS
12 years, 2 months ago (2012-08-29 12:45:12 UTC) #6
On 2012/08/28 19:45:18, gwright wrote:
> I just ran the full GM suite with -march=armv6 on my Galaxy Nexus with --nopdf
> --config 8888 and got the following:
> 
> D/skia    ( 1935): Ran 100 tests: 100 passed, 0 failed, 0 missing reference
> images

lgtm. George can email me and Eric a patch of your gyp changes for if/when we
get around to adding some ARM v6 bots?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b