Issue 6476062: Do not allow credentials files to be symlinks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6476062: Do not allow credentials files to be symlinks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by jcgregorio_google

Modified:
12 years, 10 months ago

Reviewers:
Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 3 : import order #

Total comments: 1

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -8 lines)			Patch
M	oauth2client/file.py	View	1	4 chunks	+17 lines, -0 lines	0 comments	Download
M	oauth2client/locked_file.py	View	1	4 chunks	+15 lines, -0 lines	0 comments	Download
M	oauth2client/multistore_file.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_oauth2client_file.py	View	1 2	7 chunks	+37 lines, -7 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ali Afshar

LGTM, but what is the motivation for this? https://codereview.appspot.com/6476062/diff/4001/tests/test_oauth2client_file.py File tests/test_oauth2client_file.py (right): https://codereview.appspot.com/6476062/diff/4001/tests/test_oauth2client_file.py#newcode206 tests/test_oauth2client_file.py:206: if ...

12 years, 10 months ago (2012-08-24 19:50:29 UTC) #2

jcgregorio_google

12 years, 10 months ago (2012-08-24 19:56:19 UTC) #3

On 2012/08/24 19:50:29, Ali Afshar wrote:
> LGTM, but what is the motivation for this?
> 
>
https://codereview.appspot.com/6476062/diff/4001/tests/test_oauth2client_file.py
> File tests/test_oauth2client_file.py (right):
> 
>
https://codereview.appspot.com/6476062/diff/4001/tests/test_oauth2client_file...
> tests/test_oauth2client_file.py:206: if hasattr(os, 'symlink'):
> otherwise, do nothing? I think that is OK.

Yeah, this test will only run on systems that support symlinks, i.e. it won't
run on Windows.

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=4cf5ed10d9d...

Expand All Messages | Collapse All Messages