Issue 6475068: setup: Save the dconf value "engines_order" when the order is changed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6475068: setup: Save the dconf value "engines_order" when the order is changed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by fujiwara

Modified:
10 years, 9 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Remove arrow buttons in ibus-setup, which no longer work. BUG=RH#851758 TEST=ibus-setup

Patch Set 2 : Updated with the message #2. #

Patch Set 3 : Recreated the patch to hide arrow buttons. #

Patch Set 4 : Updated with the latest master. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	setup/enginetreeview.py	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	setup/setup.ui	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6475068/diff/1/setup/main.py File setup/main.py (right): https://codereview.appspot.com/6475068/diff/1/setup/main.py#newcode289 setup/main.py:289: self.__config.set_value("general", "engines_order", value) Is it necessary to update engines_order? ...

11 years, 8 months ago (2012-08-27 14:09:32 UTC) #2

fujiwara

On 2012/08/27 14:09:32, Peng wrote: > https://codereview.appspot.com/6475068/diff/1/setup/main.py > File setup/main.py (right): > > https://codereview.appspot.com/6475068/diff/1/setup/main.py#newcode289 > ...

11 years, 8 months ago (2012-08-29 11:04:58 UTC) #3

fujiwara

Now I created the patch from the beginning. I hide the arrow buttons in ibus-setup. ...

10 years, 9 months ago (2013-07-18 08:51:38 UTC) #4

Peng

10 years, 9 months ago (2013-07-18 17:32:43 UTC) #5

On 2013/07/18 08:51:38, fujiwara wrote:
> Now I created the patch from the beginning.
> I hide the arrow buttons in ibus-setup.
> Please review this again.

lgtm

Expand All Messages | Collapse All Messages