Issue 6474068: Remove SkGpuDevice::fTexture, use new pixel ref class name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6474068: Remove SkGpuDevice::fTexture, use new pixel ref class name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 10 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Fix ref leak, rewrite ~GrResourceCache #

Patch Set 3 : Make the SkGpuDevice's pixelref always hold a ref to the texture if possible #

Total comments: 3

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -74 lines)			Patch
M	include/core/SkTDLinkedList.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	include/gpu/GrResource.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/gpu/SkGpuDevice.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1	6 chunks	+52 lines, -41 lines	3 comments	Download
M	src/gpu/GrStencilBuffer.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	5 chunks	+20 lines, -26 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

Getting rid of GrStencilBuffer::fHoldingLock made me too nervous. No one else should be locking the ...

11 years, 10 months ago (2012-08-27 19:14:52 UTC) #2

bsalomon

new patchset makes the device hold a ref to the texture instead of RT (if ...

11 years, 10 months ago (2012-08-27 19:26:51 UTC) #3

robertphillips

LGTM w/ 1 comment suggestion. https://codereview.appspot.com/6474068/diff/5001/src/gpu/GrResourceCache.cpp File src/gpu/GrResourceCache.cpp (right): https://codereview.appspot.com/6474068/diff/5001/src/gpu/GrResourceCache.cpp#newcode92 src/gpu/GrResourceCache.cpp:92: Comment here about need ...

11 years, 10 months ago (2012-08-28 11:49:56 UTC) #4

bsalomon

11 years, 10 months ago (2012-08-28 15:09:51 UTC) #5

Closed with r5307.

https://codereview.appspot.com/6474068/diff/5001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

https://codereview.appspot.com/6474068/diff/5001/src/gpu/GrResourceCache.cpp#...
src/gpu/GrResourceCache.cpp:92: 
On 2012/08/28 11:49:56, robertphillips wrote:
> Comment here about need for raw removal vs. "removeAll"?

Will do. I also renamed removeAll to purgeAllUnlocked since it's name wasn't
very accurate.

Expand All Messages | Collapse All Messages