Issue 6465073: Refactor SkImageFilter into its own .cpp file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6465073: Refactor SkImageFilter into its own .cpp file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Stephen White

Modified:
12 years ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Refactor SkImageFilter into its own .cpp file. Also remove some superfluous forward declarations and #includes.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+58 lines, -49 lines)			Patch
gyp/core.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
include/core/SkImageFilter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
include/effects/SkBlurImageFilter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
include/effects/SkMorphologyImageFilter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/core/SkImageFilter.cpp	View	1 chunk	+54 lines, -0 lines	0 comments	Download
src/core/SkPaint.cpp	View	1 chunk	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2012/08/20 15:19:04, Stephen White wrote: Mike is out this entire week, but LGTM.

12 years ago (2012-08-20 15:34:12 UTC) #2

Stephen White

12 years ago (2012-08-20 18:21:56 UTC) #3

On 2012/08/20 15:34:12, bsalomon wrote:
> On 2012/08/20 15:19:04, Stephen White wrote:
> 
> Mike is out this entire week, but LGTM.

Landed as r5188.  Closing.

Expand All Messages | Collapse All Messages