Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1727)

Issue 6465053: skdiff: recurse over subdirectories, unless --norecurse option is given (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by epoger
Modified:
12 years, 4 months ago
Reviewers:
EricB, rmistry
CC:
skia-review_googlegroups.com, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

skdiff: recurse over subdirectories, unless --norecurse option is given in anticipation of https://code.google.com/p/skia/issues/detail?id=743 ('move gm baselines outside of trunk, and modify naming convention') Committed: https://code.google.com/p/skia/source/detail?r=5121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -53 lines) Patch
M tools/skdiff_main.cpp View 12 chunks +103 lines, -23 lines 0 comments Download
D tools/tests/skdiff/baseDir/different-bits-identical-pixels.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/different-bits-unknown-format.xyz View 1 chunk +0 lines, -1 line 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/different-bits-identical-pixels.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/different-bits-unknown-format.xyz View 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/slightly-different-pixels-same-size.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/slightly-different-sizes.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/very-different-pixels-same-size.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/different-bits/very-different-sizes.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/identical-bits.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/identical-bits-unknown-format.xyz View 1 chunk +0 lines, -1 line 0 comments Download
A tools/tests/skdiff/baseDir/identical-bits/identical-bits.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/identical-bits/identical-bits-unknown-format.xyz View 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/skdiff/baseDir/missing-files/missing-from-comparisonDir.png View Binary file 0 comments Download
A tools/tests/skdiff/baseDir/missing-files/missing-from-comparisonDir.xyz View 1 chunk +1 line, -0 lines 0 comments Download
D tools/tests/skdiff/baseDir/missing-from-comparisonDir.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/missing-from-comparisonDir.xyz View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skdiff/baseDir/slightly-different-pixels-same-size.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/slightly-different-sizes.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/very-different-pixels-same-size.png View Binary file 0 comments Download
D tools/tests/skdiff/baseDir/very-different-sizes.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/different-bits-identical-pixels.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/different-bits-unknown-format.xyz View 1 chunk +0 lines, -1 line 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/different-bits-identical-pixels.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/different-bits-unknown-format.xyz View 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/slightly-different-pixels-same-size.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/slightly-different-sizes.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/very-different-pixels-same-size.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/different-bits/very-different-sizes.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/identical-bits.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/identical-bits-unknown-format.xyz View 1 chunk +0 lines, -1 line 0 comments Download
A tools/tests/skdiff/comparisonDir/identical-bits/identical-bits.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/identical-bits/identical-bits-unknown-format.xyz View 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/skdiff/comparisonDir/missing-files/missing-from-baseDir.png View Binary file 0 comments Download
A tools/tests/skdiff/comparisonDir/missing-files/missing-from-baseDir.xyz View 1 chunk +1 line, -0 lines 0 comments Download
D tools/tests/skdiff/comparisonDir/missing-from-baseDir.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/missing-from-baseDir.xyz View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skdiff/comparisonDir/slightly-different-pixels-same-size.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/slightly-different-sizes.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/very-different-pixels-same-size.png View Binary file 0 comments Download
D tools/tests/skdiff/comparisonDir/very-different-sizes.png View Binary file 0 comments Download
A tools/tests/skdiff/test1/output-expected/different-bits_slightly-different-pixels-same-size-diff.png View Binary file 0 comments Download
A tools/tests/skdiff/test1/output-expected/different-bits_slightly-different-pixels-same-size-white.png View Binary file 0 comments Download
A tools/tests/skdiff/test1/output-expected/different-bits_very-different-pixels-same-size-diff.png View Binary file 0 comments Download
A tools/tests/skdiff/test1/output-expected/different-bits_very-different-pixels-same-size-white.png View Binary file 0 comments Download
M tools/tests/skdiff/test1/output-expected/index.html View 1 chunk +11 lines, -11 lines 0 comments Download
D tools/tests/skdiff/test1/output-expected/slightly-different-pixels-same-size-diff.png View Binary file 0 comments Download
D tools/tests/skdiff/test1/output-expected/slightly-different-pixels-same-size-white.png View Binary file 0 comments Download
M tools/tests/skdiff/test1/output-expected/stdout View 1 chunk +5 lines, -5 lines 0 comments Download
D tools/tests/skdiff/test1/output-expected/very-different-pixels-same-size-diff.png View Binary file 0 comments Download
D tools/tests/skdiff/test1/output-expected/very-different-pixels-same-size-white.png View Binary file 0 comments Download
M tools/tests/skdiff/test2/output-expected/stdout View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4
epoger
This CL looks bigger than it really is. :-) There's only one source file with ...
12 years, 4 months ago (2012-08-15 14:15:08 UTC) #1
rmistry
LGTM Added Eric to reviewers to look at tools/skdiff_main.cpp for C++ readability.
12 years, 4 months ago (2012-08-16 11:40:46 UTC) #2
epoger
On 2012/08/16 11:40:46, rmistry wrote: > LGTM > > Added Eric to reviewers to look ...
12 years, 4 months ago (2012-08-16 13:33:50 UTC) #3
EricB
12 years, 4 months ago (2012-08-16 13:40:42 UTC) #4
On 2012/08/16 13:33:50, epoger wrote:
> On 2012/08/16 11:40:46, rmistry wrote:
> > LGTM
> > 
> > Added Eric to reviewers to look at 	 tools/skdiff_main.cpp for C++
> readability.
> 
> Sounds good.  Eric, I'll wait for you to take a look.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b