Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1004)

Issue 6464053: Use SkBitmapHeap for shaders in SkGPipe. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Leon
Modified:
12 years, 1 month ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Use SkBitmapHeap for shaders in SkGPipe. Required adding a new feature to SkBitmapHeap, allowing it to defer adding owners, since sometimes we flatten a shader, but then do not unflatten it, since we already had a copy in the heap, so the owners never get removed. Moved to https://codereview.appspot.com/6465047/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
M src/core/SkBitmapHeap.h View 2 chunks +19 lines, -0 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 5 chunks +27 lines, -4 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 3 chunks +18 lines, -2 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Leon
Depends on resubmitting my earlier change (still looking into the Android breakage)
12 years, 1 month ago (2012-08-13 20:26:00 UTC) #1
DerekS
12 years, 1 month ago (2012-08-14 12:31:55 UTC) #2
lgtm.  The names are starting to get a little confusing, perhaps we could think
about changing up the naming going forward (i.e. in a future CL).  In particular
fSharedHeap is not clear that it only stores bitmaps.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b