On 2012/08/20 19:17:26, bsalomon wrote: > On 2012/08/20 19:05:15, Stephen White wrote: > > LGTM ...
12 years, 3 months ago
(2012-08-20 19:38:04 UTC)
#3
On 2012/08/20 19:17:26, bsalomon wrote:
> On 2012/08/20 19:05:15, Stephen White wrote:
>
> LGTM
I think you need to add the new header to SkGlobalInitialization_default.cpp to
fix the Android build (which builds with static global initializer disabled).
On 2012/08/20 19:38:04, bsalomon wrote: > On 2012/08/20 19:17:26, bsalomon wrote: > > On 2012/08/20 ...
12 years, 3 months ago
(2012-08-20 19:45:46 UTC)
#4
On 2012/08/20 19:38:04, bsalomon wrote:
> On 2012/08/20 19:17:26, bsalomon wrote:
> > On 2012/08/20 19:05:15, Stephen White wrote:
> >
> > LGTM
>
> I think you need to add the new header to SkGlobalInitialization_default.cpp
to
> fix the Android build (which builds with static global initializer disabled).
Thanks! I was trying to grok that error. Landed as r5198.
On 2012/08/20 19:45:46, Stephen White wrote: > On 2012/08/20 19:38:04, bsalomon wrote: > > On ...
12 years, 3 months ago
(2012-08-20 19:58:26 UTC)
#5
On 2012/08/20 19:45:46, Stephen White wrote:
> On 2012/08/20 19:38:04, bsalomon wrote:
> > On 2012/08/20 19:17:26, bsalomon wrote:
> > > On 2012/08/20 19:05:15, Stephen White wrote:
> > >
> > > LGTM
> >
> > I think you need to add the new header to SkGlobalInitialization_default.cpp
> to
> > fix the Android build (which builds with static global initializer
disabled).
>
> Thanks! I was trying to grok that error. Landed as r5198.
Er, that should be r5199. Which doesn't seem to be showing up on the waterfall,
for some reason.
Issue 6463072: Refactor SkColorFilterImageFilter into its own file
(Closed)
Created 12 years, 3 months ago by Stephen White
Modified 12 years, 3 months ago
Reviewers: bsalomon, reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0