Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(918)

Issue 6463072: Refactor SkColorFilterImageFilter into its own file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Stephen White
Modified:
12 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Refactor SkColorFilterImageFilter into its own file

Patch Set 1 #

Patch Set 2 : Remove a now-redundant #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -69 lines) Patch
M gm/imagefiltersbase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gm/testimagefilters.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/effects.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A include/effects/SkColorFilterImageFilter.h View 1 chunk +35 lines, -0 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 2 chunks +0 lines, -24 lines 0 comments Download
src/effects/SkColorFilterImageFilter.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 2 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 6
Stephen White
12 years, 3 months ago (2012-08-20 19:05:15 UTC) #1
bsalomon
On 2012/08/20 19:05:15, Stephen White wrote: LGTM
12 years, 3 months ago (2012-08-20 19:17:26 UTC) #2
bsalomon
On 2012/08/20 19:17:26, bsalomon wrote: > On 2012/08/20 19:05:15, Stephen White wrote: > > LGTM ...
12 years, 3 months ago (2012-08-20 19:38:04 UTC) #3
Stephen White
On 2012/08/20 19:38:04, bsalomon wrote: > On 2012/08/20 19:17:26, bsalomon wrote: > > On 2012/08/20 ...
12 years, 3 months ago (2012-08-20 19:45:46 UTC) #4
Stephen White
On 2012/08/20 19:45:46, Stephen White wrote: > On 2012/08/20 19:38:04, bsalomon wrote: > > On ...
12 years, 3 months ago (2012-08-20 19:58:26 UTC) #5
Stephen White
12 years, 3 months ago (2012-08-20 20:45:19 UTC) #6
Landed as r5197; closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b