Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 6463048: Codel, fq_codel in ns3

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by Tom Henderson
Modified:
6 years, 8 months ago
CC:
ns-3-reviews_googlegroups.com, dave.taht
Visibility:
Public.

Description

As discussed here; http://mailman.isi.edu/pipermail/ns-developers/2012-August/010572.html Andrew Mcgregor has developed some ns3 models of Kathie Nichols' and Van Jacobson's new codel algorithm and also incorporated Eric Dumazet's fq_codel derivative... this is an early request for feedback, not yet a merge request

Patch Set 1 #

Total comments: 23
Unified diffs Side-by-side diffs Delta from patch set Stats (+1971 lines, -1 line) Patch
A scratch/tcp-qfp.cc View 1 chunk +455 lines, -0 lines 5 comments Download
A src/core/model/linux-list.h View 1 chunk +264 lines, -0 lines 2 comments Download
M src/core/wscript View 1 chunk +1 line, -0 lines 0 comments Download
A src/internet/model/fq_codel-queue.h View 1 chunk +87 lines, -0 lines 4 comments Download
A src/internet/model/fq_codel-queue.cc View 1 chunk +231 lines, -0 lines 1 comment Download
A src/internet/model/sfq-queue.h View 1 chunk +80 lines, -0 lines 1 comment Download
A src/internet/model/sfq-queue.cc View 1 chunk +232 lines, -0 lines 3 comments Download
M src/internet/model/tcp-socket-base.cc View 2 chunks +2 lines, -1 line 3 comments Download
M src/internet/wscript View 2 chunks +4 lines, -0 lines 0 comments Download
A src/network/utils/codel-queue.h View 1 chunk +129 lines, -0 lines 3 comments Download
A src/network/utils/codel-queue.cc View 1 chunk +478 lines, -0 lines 0 comments Download
M src/network/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/point-to-point/model/point-to-point-net-device.cc View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 9
Tom Henderson
This looks really good in general. Mainly missing tests and documentation (both doxygen and also ...
6 years, 11 months ago (2012-08-17 21:19:31 UTC) #1
john.abraham.in
http://codereview.appspot.com/6463048/diff/1/scratch/tcp-qfp.cc File scratch/tcp-qfp.cc (right): http://codereview.appspot.com/6463048/diff/1/scratch/tcp-qfp.cc#newcode20 scratch/tcp-qfp.cc:20: // uses boost::format Please note that using third-party libraries ...
6 years, 11 months ago (2012-08-17 21:57:03 UTC) #2
Mathieu Lacage
It's nice to see this feature coming in ! Hopefully, you were looking for great ...
6 years, 10 months ago (2012-08-21 16:02:18 UTC) #3
andrewmcgr
On 2012/08/21 16:02:18, Mathieu Lacage wrote: > It's nice to see this feature coming in ...
6 years, 10 months ago (2012-08-21 22:27:54 UTC) #4
andrewmcgr
On 2012/08/17 21:57:03, john.abraham.in wrote: > http://codereview.appspot.com/6463048/diff/1/scratch/tcp-qfp.cc > File scratch/tcp-qfp.cc (right): > > http://codereview.appspot.com/6463048/diff/1/scratch/tcp-qfp.cc#newcode20 > ...
6 years, 10 months ago (2012-08-21 22:29:33 UTC) #5
Tommaso Pecorella
This is a very welcome set of functionalities to be added to ns-3. Beside other ...
6 years, 8 months ago (2012-11-10 22:56:39 UTC) #6
dave.taht
I am certain I won't have time this year to get this into ns3. Help? ...
6 years, 8 months ago (2012-11-11 00:31:55 UTC) #7
andrewmcgr
I have a few comments inline. My time will be very short over the next ...
6 years, 8 months ago (2012-11-11 22:43:11 UTC) #8
Tom Henderson
6 years, 8 months ago (2012-11-12 19:29:33 UTC) #9
http://codereview.appspot.com/6463048/diff/1/src/internet/model/tcp-socket-ba...
File src/internet/model/tcp-socket-base.cc (right):

http://codereview.appspot.com/6463048/diff/1/src/internet/model/tcp-socket-ba...
src/internet/model/tcp-socket-base.cc:109: m_nextTxSequence (std::rand ()),
On 2012/11/10 22:56:39, Tommaso Pecorella wrote:
> beside Tom's comment, this change is not strictly related to CoDel. My
> suggestion is to open a bug and propose a change in main ns-3 code.

Here is the bug/feature request:
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1529
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b