Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1427)

Issue 6463047: Added functions that provide information for block and glyph coverage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by yehh
Modified:
12 years, 7 months ago
Reviewers:
stuartg
CC:
bstell1
Base URL:
http://sfntly.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added functions that provide information for block and glyph coverage. Notes: - The current method for loading in block names and ranges is temporary, FIXME message has been attached. - Current method of calculating blocks iterates by block and creates a UnicodeSet per block, which is extremely inefficient. A better algorithm would be to iterate by the valid code points in the font. However, ICU does not provide a function that provides the full English name of each block, and I will need to think of a way to create such a mapping that deals with exceptions gracefully.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Modified files according to code reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+851 lines, -0 lines) Patch
M java/src/com/google/typography/font/tools/fontinfo/FontInfo.java View 1 2 chunks +162 lines, -0 lines 0 comments Download
A java/src/com/google/typography/font/tools/fontinfo/UnicodeBlockData.java View 1 1 chunk +689 lines, -0 lines 0 comments Download

Messages

Total messages: 5
yehh
http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontInfo.java File java/src/com/google/typography/font/tools/fontinfo/FontInfo.java (right): http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontInfo.java#newcode393 java/src/com/google/typography/font/tools/fontinfo/FontInfo.java:393: * Gets a list of characters needed to fully ...
12 years, 7 months ago (2012-08-13 23:40:15 UTC) #1
yehh
http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontInfo.java File java/src/com/google/typography/font/tools/fontinfo/FontInfo.java (right): http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontInfo.java#newcode293 java/src/com/google/typography/font/tools/fontinfo/FontInfo.java:293: // TODO Iterate by code points in the font. ...
12 years, 7 months ago (2012-08-14 00:17:49 UTC) #2
stuartg
http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/UnicodeBlockData.java File java/src/com/google/typography/font/tools/fontinfo/UnicodeBlockData.java (right): http://codereview.appspot.com/6463047/diff/1/java/src/com/google/typography/font/tools/fontinfo/UnicodeBlockData.java#newcode5 java/src/com/google/typography/font/tools/fontinfo/UnicodeBlockData.java:5: */ Please state the source and version of the ...
12 years, 7 months ago (2012-08-14 00:38:24 UTC) #3
yehh
Modified code according to code reviews, updated new patch set.
12 years, 7 months ago (2012-08-14 01:09:13 UTC) #4
stuartg
12 years, 7 months ago (2012-08-14 01:10:30 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b