Issue 6463046: Refactored inspector widget such that creating custom tabs for information is straightforward for f…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6463046: Refactored inspector widget such that creating custom tabs for information is straightforward for f… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by chudy

Modified:
12 years, 3 months ago

Reviewers:
EricB, DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Refactored inspector widget such that creating custom tabs for information is straightforward for future developers. Committed: https://code.google.com/p/skia/source/detail?r=5093

Patch Set 2 : Addressed Dereks comments #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -43 lines)			Patch
M	debugger/QT/SkDebuggerGUI.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	debugger/QT/SkInspectorWidget.h	View	1	3 chunks	+27 lines, -14 lines	0 comments	Download
M	debugger/QT/SkInspectorWidget.cpp	View	1	4 chunks	+15 lines, -27 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/6463046/diff/5001/debugger/QT/SkInspectorWidget.h File debugger/QT/SkInspectorWidget.h (right): https://codereview.appspot.com/6463046/diff/5001/debugger/QT/SkInspectorWidget.h#newcode33 debugger/QT/SkInspectorWidget.h:33: kDetailTab = 1, rename them to use the following ...

12 years, 3 months ago (2012-08-13 18:17:47 UTC) #2

chudy

http://codereview.appspot.com/6463046/diff/5001/debugger/QT/SkInspectorWidget.h File debugger/QT/SkInspectorWidget.h (right): http://codereview.appspot.com/6463046/diff/5001/debugger/QT/SkInspectorWidget.h#newcode33 debugger/QT/SkInspectorWidget.h:33: kDetailTab = 1, On 2012/08/13 18:17:47, DerekS wrote: > ...

12 years, 3 months ago (2012-08-14 19:23:01 UTC) #3

Committed in revision 5093. Thanks for the review

Expand All Messages | Collapse All Messages